Hi Matthew, Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master] [cannot apply to v5.3-rc4 next-20190816] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Matthew-Hanzelik/Staging-speakup-spk_types-fixed-an-unnamed-parameter-style-issue/20190817-235230 config: x86_64-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.4.0-10) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <l...@intel.com> All warnings (new ones prefixed by >>): drivers/staging/speakup/serialio.c: In function 'synth_readbuf_handler': >> drivers/staging/speakup/serialio.c:120:24: warning: passing argument 1 of >> 'synth->read_buff_add' makes pointer from integer without a cast >> [-Wint-conversion] synth->read_buff_add((u_char)c); ^ drivers/staging/speakup/serialio.c:120:24: note: expected 'u_char * {aka unsigned char *}' but argument is of type 'unsigned char' -- drivers/staging/speakup/spk_ttyio.c: In function 'spk_ttyio_receive_buf2': >> drivers/staging/speakup/spk_ttyio.c:82:35: warning: passing argument 1 of >> 'spk_ttyio_synth->read_buff_add' makes pointer from integer without a cast >> [-Wint-conversion] spk_ttyio_synth->read_buff_add(cp[i]); ^~ drivers/staging/speakup/spk_ttyio.c:82:35: note: expected 'u_char * {aka unsigned char *}' but argument is of type 'unsigned char' vim +120 drivers/staging/speakup/serialio.c c6e3fd22cd5383 William Hubbs 2010-10-07 111 c6e3fd22cd5383 William Hubbs 2010-10-07 112 static irqreturn_t synth_readbuf_handler(int irq, void *dev_id) c6e3fd22cd5383 William Hubbs 2010-10-07 113 { c6e3fd22cd5383 William Hubbs 2010-10-07 114 unsigned long flags; c6e3fd22cd5383 William Hubbs 2010-10-07 115 int c; 8e69a811068657 Domagoj Trsan 2014-09-09 116 9fb31b1abdabab William Hubbs 2013-05-13 117 spin_lock_irqsave(&speakup_info.spinlock, flags); c6e3fd22cd5383 William Hubbs 2010-10-07 118 while (inb_p(speakup_info.port_tts + UART_LSR) & UART_LSR_DR) { c6e3fd22cd5383 William Hubbs 2010-10-07 119 c = inb_p(speakup_info.port_tts + UART_RX); c6e3fd22cd5383 William Hubbs 2010-10-07 @120 synth->read_buff_add((u_char)c); c6e3fd22cd5383 William Hubbs 2010-10-07 121 } 9fb31b1abdabab William Hubbs 2013-05-13 122 spin_unlock_irqrestore(&speakup_info.spinlock, flags); c6e3fd22cd5383 William Hubbs 2010-10-07 123 return IRQ_HANDLED; c6e3fd22cd5383 William Hubbs 2010-10-07 124 } c6e3fd22cd5383 William Hubbs 2010-10-07 125 :::::: The code at line 120 was first introduced by commit :::::: c6e3fd22cd538365bfeb82997d5b89562e077d42 Staging: add speakup to the staging directory :::::: TO: William Hubbs <w.d.hu...@gmail.com> :::::: CC: Greg Kroah-Hartman <gre...@suse.de> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
_______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
