Hi Matthew,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc6 next-20190827]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Matthew-Hanzelik/Staging-speakup-spk_types-fixed-an-unnamed-parameter-style-issue/20190817-235230
config: c6x-allyesconfig (attached as .config)
compiler: c6x-elf-gcc (GCC) 7.4.0
reproduce:
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=c6x 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <l...@intel.com>

All errors (new ones prefixed by >>):

>> drivers/staging/speakup/speakup_dectlk.c:132:19: error: initialization from 
>> incompatible pointer type [-Werror=incompatible-pointer-types]
     .read_buff_add = read_buff_add,
                      ^~~~~~~~~~~~~
   drivers/staging/speakup/speakup_dectlk.c:132:19: note: (near initialization 
for 'synth_dectlk.read_buff_add')
   cc1: some warnings being treated as errors
--
>> drivers/staging/speakup/speakup_decext.c:126:19: error: initialization from 
>> incompatible pointer type [-Werror=incompatible-pointer-types]
     .read_buff_add = read_buff_add,
                      ^~~~~~~~~~~~~
   drivers/staging/speakup/speakup_decext.c:126:19: note: (near initialization 
for 'synth_decext.read_buff_add')
   cc1: some warnings being treated as errors

vim +132 drivers/staging/speakup/speakup_dectlk.c

c6e3fd22cd5383 William Hubbs 2010-10-07  106  
c6e3fd22cd5383 William Hubbs 2010-10-07  107  static struct spk_synth 
synth_dectlk = {
c6e3fd22cd5383 William Hubbs 2010-10-07  108    .name = "dectlk",
c6e3fd22cd5383 William Hubbs 2010-10-07  109    .version = DRV_VERSION,
c6e3fd22cd5383 William Hubbs 2010-10-07  110    .long_name = "Dectalk Express",
c6e3fd22cd5383 William Hubbs 2010-10-07  111    .init = "[:error sp :name paul 
:rate 180 :tsr off] ",
c6e3fd22cd5383 William Hubbs 2010-10-07  112    .procspeech = PROCSPEECH,
c6e3fd22cd5383 William Hubbs 2010-10-07  113    .clear = SYNTH_CLEAR,
c6e3fd22cd5383 William Hubbs 2010-10-07  114    .delay = 500,
c6e3fd22cd5383 William Hubbs 2010-10-07  115    .trigger = 50,
c6e3fd22cd5383 William Hubbs 2010-10-07  116    .jiffies = 50,
c6e3fd22cd5383 William Hubbs 2010-10-07  117    .full = 40000,
8a21ff775f5654 Okash Khawaja 2017-06-25  118    .dev_name = SYNTH_DEFAULT_DEV,
c6e3fd22cd5383 William Hubbs 2010-10-07  119    .startup = SYNTH_START,
c6e3fd22cd5383 William Hubbs 2010-10-07  120    .checkval = SYNTH_CHECK,
c6e3fd22cd5383 William Hubbs 2010-10-07  121    .vars = vars,
c6e3fd22cd5383 William Hubbs 2010-10-07  122    .default_pitch = ap_defaults,
c6e3fd22cd5383 William Hubbs 2010-10-07  123    .default_vol = g5_defaults,
470790eefede39 Okash Khawaja 2017-05-15  124    .io_ops = &spk_ttyio_ops,
470790eefede39 Okash Khawaja 2017-05-15  125    .probe = spk_ttyio_synth_probe,
470790eefede39 Okash Khawaja 2017-05-15  126    .release = spk_ttyio_release,
470790eefede39 Okash Khawaja 2017-05-15  127    .synth_immediate = 
spk_ttyio_synth_immediate,
c6e3fd22cd5383 William Hubbs 2010-10-07  128    .catch_up = do_catch_up,
c6e3fd22cd5383 William Hubbs 2010-10-07  129    .flush = synth_flush,
c6e3fd22cd5383 William Hubbs 2010-10-07  130    .is_alive = 
spk_synth_is_alive_restart,
c6e3fd22cd5383 William Hubbs 2010-10-07  131    .synth_adjust = NULL,
c6e3fd22cd5383 William Hubbs 2010-10-07 @132    .read_buff_add = read_buff_add,
c6e3fd22cd5383 William Hubbs 2010-10-07  133    .get_index = get_index,
c6e3fd22cd5383 William Hubbs 2010-10-07  134    .indexing = {
c6e3fd22cd5383 William Hubbs 2010-10-07  135            .command = "[:in re %d 
] ",
c6e3fd22cd5383 William Hubbs 2010-10-07  136            .lowindex = 1,
c6e3fd22cd5383 William Hubbs 2010-10-07  137            .highindex = 8,
c6e3fd22cd5383 William Hubbs 2010-10-07  138            .currindex = 1,
c6e3fd22cd5383 William Hubbs 2010-10-07  139    },
c6e3fd22cd5383 William Hubbs 2010-10-07  140    .attributes = {
c6e3fd22cd5383 William Hubbs 2010-10-07  141            .attrs = synth_attrs,
c6e3fd22cd5383 William Hubbs 2010-10-07  142            .name = "dectlk",
c6e3fd22cd5383 William Hubbs 2010-10-07  143    },
c6e3fd22cd5383 William Hubbs 2010-10-07  144  };
c6e3fd22cd5383 William Hubbs 2010-10-07  145  

:::::: The code at line 132 was first introduced by commit
:::::: c6e3fd22cd538365bfeb82997d5b89562e077d42 Staging: add speakup to the 
staging directory

:::::: TO: William Hubbs <w.d.hu...@gmail.com>
:::::: CC: Greg Kroah-Hartman <gre...@suse.de>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to