On 08/10/2019 08:41, zhengbin wrote:
Fixes gcc '-Wunused-but-set-variable' warning:drivers/staging/comedi/drivers/dt2814.c: In function dt2814_interrupt: drivers/staging/comedi/drivers/dt2814.c:193:6: warning: variable data set but not used [-Wunused-but-set-variable] It is not used since commit 7806012e97ed ("staging: comedi: refactor dt2814 driver and use module_comedi_driver") Reported-by: Hulk Robot <hul...@huawei.com> Signed-off-by: zhengbin <zhengbi...@huawei.com> --- drivers/staging/comedi/drivers/dt2814.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/dt2814.c b/drivers/staging/comedi/drivers/dt2814.c index d2c7157..4825168 100644 --- a/drivers/staging/comedi/drivers/dt2814.c +++ b/drivers/staging/comedi/drivers/dt2814.c @@ -190,7 +190,6 @@ static irqreturn_t dt2814_interrupt(int irq, void *d) struct comedi_device *dev = d; struct dt2814_private *devpriv = dev->private; struct comedi_subdevice *s = dev->read_subdev; - int data; if (!dev->attached) { dev_err(dev->class_dev, "spurious interrupt\n"); @@ -200,8 +199,6 @@ static irqreturn_t dt2814_interrupt(int irq, void *d) hi = inb(dev->iobase + DT2814_DATA); lo = inb(dev->iobase + DT2814_DATA); - data = (hi << 4) | (lo >> 4); - if (!(--devpriv->ntrig)) { int i; -- 2.7.4
There is something fishy going on there. The driver ought to be writing the data to a buffer.
Can I suggest omitting this patch from the series so I can investigate and supply a proper fix?
-- -=( Ian Abbott <abbo...@mev.co.uk> || Web: www.mev.co.uk )=- -=( MEV Ltd. is a company registered in England & Wales. )=- -=( Registered number: 02862268. Registered address: )=- -=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=- _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
