On Tue, Oct 08, 2019 at 01:56:49PM +0100, Ian Abbott wrote:
> On 08/10/2019 08:41, zhengbin wrote:
> > Fixes gcc '-Wunused-but-set-variable' warning:
> >
> > drivers/staging/comedi/drivers/dt2815.c: In function dt2815_ao_insn:
> > drivers/staging/comedi/drivers/dt2815.c:91:19: warning: variable hi set but
> > not used [-Wunused-but-set-variable]
> >
> > It is not used since commit d6a929b7608a ("Staging:
> > comedi: add dt2815 driver")
> >
> > Reported-by: Hulk Robot <hul...@huawei.com>
> > Signed-off-by: zhengbin <zhengbi...@huawei.com>
> > ---
> > drivers/staging/comedi/drivers/dt2815.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/comedi/drivers/dt2815.c
> > b/drivers/staging/comedi/drivers/dt2815.c
> > index 83026ba..bcf85ec 100644
> > --- a/drivers/staging/comedi/drivers/dt2815.c
> > +++ b/drivers/staging/comedi/drivers/dt2815.c
> > @@ -88,12 +88,11 @@ static int dt2815_ao_insn(struct comedi_device *dev,
> > struct comedi_subdevice *s,
> > struct dt2815_private *devpriv = dev->private;
> > int i;
> > int chan = CR_CHAN(insn->chanspec);
> > - unsigned int lo, hi;
> > + unsigned int lo;
> > int ret;
> >
> > for (i = 0; i < insn->n; i++) {
> > lo = ((data[i] & 0x0f) << 4) | (chan << 1) | 0x01;
> > - hi = (data[i] & 0xff0) >> 4;
> >
> > ret = comedi_timeout(dev, s, insn, dt2815_ao_status, 0x00);
> > if (ret)
> > --
> > 2.7.4
> >
>
> There is something fishy going on in this one too. It should be writing the
> 'hi' value to the card registers.
>
> Please could you omit this patch from the series so I can investigate?
Now dropped, thanks.
greg k-h
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
