Hi, I merged charset declarations of global_charset_info.h and charset_info.h into charset.h header file.
After that I needed to remove global_charset_info.h and charset_info.h header declarations from all the drizzle code base. I wrote a script that search for global_charset_info.h in all the source code files and replace it with charset.h if that file does not already have charset.h header declaration otherwise it just remove global_charset_info.h from that particular file. I wrote a smilar scrpt for replacing charset_info.h with charset.h I then restructured charset.h in order to make it more structural. i.e All the extern declarations are consolidated together one after the other. Similar pattern has been followed for struct declarations and functions in the charset.h header file After all the changes, I build and run the test as follows: ./config/autorun.sh ./configure make make test All tests ran successfully and I got the following result: Stopping All Servers All 564 tests were successful. The servers were restarted 55 times Spent 399.741 of 704 seconds executing testcases I followed the following instructions for committing and pushing up the changes: http://docs.drizzle.org/contributing/code.html#code-label 1) bzr commit --fixes lp:621859 Committed revision 2260. 2) bzr push lp:~mumair/drizzle/trunk-bug-621859 Using default stacking branch /~drizzle-developers/drizzle/development at lp-80189136:///~mumair/drizzle Created new stacked branch referring to /~drizzle-developers/drizzle/development. This is a great learning experience for me and I am sure that I will learn about Drizzle more and more in the coming days. I am thankful for all the guidance. It really helped me a lot in setting up a strong base to contribute in Drizzle codebase. Please suggest any changes or improvements in the task that I implemented Many Thanks. Umair Muhammad Electrical Engineering Master Student, Specialization in Wireless Systems, School of Electrical Engineering, Royal Institute of Technology (KTH), SE 100-44 Stockholm, SWEDEN. Email: [email protected] Cell: +46 764 097 574 _______________________________________________ Mailing list: https://launchpad.net/~drizzle-discuss Post to : [email protected] Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
