On Sun, Apr 10, 2011 at 10:40 PM, Muhammad Umair <[email protected]> wrote:
> This is a great learning experience for me and I am sure that I will learn 
> about Drizzle more and more in the coming days. I am thankful for all the 
> guidance. It really helped me a lot in setting up a strong base to contribute 
> in Drizzle codebase. Please suggest any changes or improvements in the task 
> that I implemented

Nice work.

Some questions:
Why did you touch the copyright header in drizzled/charset.h?

The line "#include <drizzled/charset_info.h>" could've been removed
instead of replaced by an empty line.

Greetings,


-- 
Olaf

_______________________________________________
Mailing list: https://launchpad.net/~drizzle-discuss
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~drizzle-discuss
More help   : https://help.launchpad.net/ListHelp

Reply via email to