On Thu, Dec 8, 2011 at 11:37 PM, Daniel Nichter <[email protected]> wrote: > If other people think this is a good idea, the next question is: > DRIZZLE_PLUGIN or DRIZZLE_DECLARE_PLUGIN? Why not use just one? But which > one? Hingo said in another thread that DRIZZLE_DECLARE_PLUGIN is newer, but > I prefer DRIZZLE_PLUGIN because it's shorter and forces all the plugin's > metadata (authors, version, etc.) into its plugin.ini, and since I don't > think we can get rid of the plugin.ini, it seems logical to me to centralize > metadata in it. >
You're refering to a merge review of auth_ldap documentation. The reason I changed it was that I got build errors with DRIZZLE_PLUGIN when I added more than one author: "Eric Day <email>, Henrik Ingo <email>, Edward Koko Konetzko <email>". I didn't investigate it further but it seemed like the commas make this string interpreted as 3 arguments somewhere in the build process where 1 is expected. With DRIZZLE_DECLARE_PLUGIN it works. (But you could of course fix DRIZZLE_DECLARE_PLUGIN. I agree there should only be one. There is a related issue here: Currently the system is designed to just support one author string. So in the data dictionary modules table you will find the authors column contains: John Doe John Smith John Doe, John Smith John Smith, John Doe All of which are separate 4 separate "authors". It seems like DRIZZLE_DECLARE_PLUGIN should officially understand commas, and then put all the authors in a separate MODULE_AUTHORS table (1:n relation). (I have no intention of implementing that, just pointing it out.) henrik -- [email protected] +358-40-8211286 skype: henrik.ingo irc: hingo www.openlife.cc My LinkedIn profile: http://www.linkedin.com/profile/view?id=9522559 _______________________________________________ Mailing list: https://launchpad.net/~drizzle-discuss Post to : [email protected] Unsubscribe : https://launchpad.net/~drizzle-discuss More help : https://help.launchpad.net/ListHelp
