On 01/29/2012 11:16 PM, pcrews wrote:
On 01/29/2012 09:46 PM, Mark Atwood wrote:
Hi!
We have lp:~patrick-crews/drizzle/qp-merge2 sitting in the Branch
Merge Proposal list on Launchpad.
It is 166905 lines, which is just over 10% of the existing 1431202 lines.
I only really noticed it's huge size when I was trying to run the
merge last week while I was in Australia, and BZR had taken over 10
minutes before I aborted it.
On the other hand, it appears that the existing dbqp is itself nearly
as big.
It appears to me that kewpie contains code to also test stock MySQL
and to test Percona server. While I am a fan of putting the test code
in-tree (it certainly makes parts of my own Drizzle work much easier),
I have hesitations about carrying around the weight of test code for
other projects as well.
Any thoughts about my concerns? Or should I just suck it up and merge it?
..m
Hi. It is pretty darned huge as it has the randgen + sql-bench in there
as well as tests, etc and I was wondering about this myself.
Here are two suggestions:
1) I can remove the Percona stuff. Apologies for not having done it
sooner, but I was thinking some tests would prove useful over time, like
the cluster_* and xtrabackup_* suites. However, a fair bit of this won't
be needed.
2) We've been discussing this for Percona projects: Have the test code
live outside the tree and simply keep a config file in the drizzle tree
that says things like "I am a drizzle server. This is my basedir. Run
these suites, etc"
I'll have an updated branch with #1 done tomorrow. Let me know what you
guys think about #2.
--
Patrick
_______________________________________________
Mailing list: https://launchpad.net/~drizzle-discuss
Post to : [email protected]
Unsubscribe : https://launchpad.net/~drizzle-discuss
More help : https://help.launchpad.net/ListHelp
The only other thing I would add in regards to keeping the code to run
MySQL + variants is that we are working on server-server compare suites
with the randgen and we'll need to know how to find files + run for
them. As for the tests, we can completely remove percona_tests dir and
add in things as needed. See you in #drizzle in the am : )
Patrick
_______________________________________________
Mailing list: https://launchpad.net/~drizzle-discuss
Post to : [email protected]
Unsubscribe : https://launchpad.net/~drizzle-discuss
More help : https://help.launchpad.net/ListHelp
