[
https://issues.apache.org/jira/browse/DROIDS-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976475#action_12976475
]
Otis Gospodnetic commented on DROIDS-113:
-----------------------------------------
mvn clean test passes before patch, and after the patch:
testReportCrawlingDroid(org.apache.droids.dynamic.TestSimpleDroid) Time
elapsed: 1.74 sec <<< FAILURE!
junit.framework.AssertionFailedError: expected:<5> but was:<1>
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.failNotEquals(Assert.java:277)
at junit.framework.Assert.assertEquals(Assert.java:64)
at junit.framework.Assert.assertEquals(Assert.java:195)
at junit.framework.Assert.assertEquals(Assert.java:201)
at
org.apache.droids.dynamic.TestSimpleDroid.testReportCrawlingDroid(TestSimpleDroid.java:72)
> RegexURLFilter uses find() instead of matches() to match the regex
> ------------------------------------------------------------------
>
> Key: DROIDS-113
> URL: https://issues.apache.org/jira/browse/DROIDS-113
> Project: Droids
> Issue Type: Bug
> Components: core
> Affects Versions: 0.0.1
> Reporter: Eugen Paraschiv
> Fix For: 0.0.1
>
> Attachments: DROIDS-113_v1.patch
>
>
> By matching the regex via find() and not matches(), the client doesn't have
> full control over the url matching process, because the regex is not used to
> match the entire url but any part of it, which may not be correct.
> If the client wants to allow flexibility in the URL structure, he can do so
> with the regex expression itself, but the actual matching process should try
> to match the entire url, not just parts of it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
