[ 
https://issues.apache.org/jira/browse/DROIDS-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eugen Paraschiv updated DROIDS-113:
-----------------------------------

    Attachment: DROIDS-113_v2.patch

This patch addresses the reported issue. The reason it failed is because, as 
the description reads, the entire string is not matched on, so the default, 
accepting regex (which was just '.') should now be .* to accept everything. 

> RegexURLFilter uses find() instead of matches() to match the regex
> ------------------------------------------------------------------
>
>                 Key: DROIDS-113
>                 URL: https://issues.apache.org/jira/browse/DROIDS-113
>             Project: Droids
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.0.1
>            Reporter: Eugen Paraschiv
>             Fix For: 0.0.1
>
>         Attachments: DROIDS-113_v1.patch, DROIDS-113_v2.patch
>
>
> By matching the regex via find() and not matches(), the client doesn't have 
> full control over the url matching process, because the regex is not used to 
> match the entire url but any part of it, which may not be correct. 
> If the client wants to allow flexibility in the URL structure, he can do so 
> with the regex expression itself, but the actual matching process should try 
> to match the entire url, not just parts of it. 

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to