[
https://issues.apache.org/jira/browse/DROIDS-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995029#comment-12995029
]
Eugen Paraschiv commented on DROIDS-56:
---------------------------------------
The current SimpleTaskQueue, besides providing the underlying data structure
and operations, also executes validation logic on the individual tasks, when
these are added to the data structure. It seems that the current patch removes
this validation but doesn't added anywhere else. Is there something I'm
missing? I have only been looking at a specific part of this patch, so I may be
off base.
Nice addition to the codebase, hope this gets committed soon.
> Change the TaskQueue interface to java.util.Queue
> -------------------------------------------------
>
> Key: DROIDS-56
> URL: https://issues.apache.org/jira/browse/DROIDS-56
> Project: Droids
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.0.1
> Reporter: Mingfai Ma
> Attachments: Queue.diff, droids-56-v2.diff, droids-56.diff,
> taskQueue-to-queue.diff
>
>
> 1. any code that depends on the queue should depend on java.util.Queue<T>
> rather than TaskQueue.
> 2. either remove the TaskQueue or make it extends java.util.Queue
> - it means SimpleTaskQueue should extends a Queue implementation (or
> implement all method of a Queue)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
