[
https://issues.apache.org/jira/browse/DROIDS-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995989#comment-12995989
]
Richard Frovarp commented on DROIDS-106:
----------------------------------------
The one thing I see here is a small bit of inconsistency. There is a
checkNotNull method that is used once in the patch. Otherwise checkState and
checkArgument are used to test for nullness. Reading the documentation, I think
the checkArgument null checks should be replaced with checkNotNull. The patch
as is works, we just might want to change some of those calls later to be more
consistent.
> Introduce Guava (the former google collections) into the droids project
> -----------------------------------------------------------------------
>
> Key: DROIDS-106
> URL: https://issues.apache.org/jira/browse/DROIDS-106
> Project: Droids
> Issue Type: Wish
> Components: core
> Affects Versions: 0.0.1
> Reporter: Eugen Paraschiv
> Fix For: 0.0.1
>
> Attachments: DROIDS-106.patch
>
>
> Google Guava is becoming a standard extension to the collection framework and
> provides some very useful features (besides the obvious collection work which
> is extensive), such as Preconditions (which would standardize the way
> argument checking is done).
> As far as I know, many other Apache projects use Guava (Mahout is one).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
