[ 
https://issues.apache.org/jira/browse/DROIDS-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995999#comment-12995999
 ] 

Eugen Paraschiv commented on DROIDS-106:
----------------------------------------

The reason behind the checkNotNull usage is this - my goal was to make sure 
that I wasn't breaking any APIs, so even if I wanted to use the checkNotNull 
method more often, I couldn't do that if I wanted to maintain the exact type of 
exception that was being thrown before the patch. Now in the case I did use 
checkNotNull, the exception being thrown was RuntimeException, so the fact that 
a NullPointerException is thrown there doesn't break the API. 
Now that being said, I would want to propose a new issue to use the check___ 
methods of the Guava Preconditions API to their full potential, later on. 
Hope that clarifies things a bit. 
Thanks a lot for the feedback. 

> Introduce Guava (the former google collections) into the droids project
> -----------------------------------------------------------------------
>
>                 Key: DROIDS-106
>                 URL: https://issues.apache.org/jira/browse/DROIDS-106
>             Project: Droids
>          Issue Type: Wish
>          Components: core
>    Affects Versions: 0.0.1
>            Reporter: Eugen Paraschiv
>             Fix For: 0.0.1
>
>         Attachments: DROIDS-106.patch
>
>
> Google Guava is becoming a standard extension to the collection framework and 
> provides some very useful features (besides the obvious collection work which 
> is extensive), such as Preconditions (which would standardize the way 
> argument checking is done). 
> As far as I know, many other Apache projects use Guava (Mahout is one). 

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to