[ 
https://issues.apache.org/jira/browse/DROIDS-150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135331#comment-13135331
 ] 

Javier Puerto commented on DROIDS-150:
--------------------------------------

Thanks for the contribution!!
I've enclosed the Reader close statement in a finally block. I think it's 
necessary because the method read could thrown an exception an leave the stream 
open.
Also, why is the rules object initialized to 16?
                
> Inputstream not close after file read when loading regex filters in 
> RegexURLFilter class
> ----------------------------------------------------------------------------------------
>
>                 Key: DROIDS-150
>                 URL: https://issues.apache.org/jira/browse/DROIDS-150
>             Project: Droids
>          Issue Type: Bug
>          Components: core
>    Affects Versions: Graduating from the Incubator
>         Environment: All
>            Reporter: Tony Dietrich
>            Priority: Minor
>              Labels: fix, patch
>             Fix For: Graduating from the Incubator
>
>         Attachments: RegexYRLFilter_diff.patch
>
>
> Inputstream not closed from RegexURLFilter after loading from classpath or 
> disk file
> Patch attached

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to