[
https://issues.apache.org/jira/browse/DROIDS-150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135420#comment-13135420
]
Tony Dietrich commented on DROIDS-150:
--------------------------------------
Latest java specs say that although its not neccessary to initialise a
collection, it is always preferrable to initialise it. I've got into the habit,
and my IDE nags me if I don't. 16 gives the array some headroom.
Good spot with the try..finally block, although if we ever update to JDK7 we
could change that to a try-with-resources block, since InptuStream is a
Closeable. Should we explicitly re-throw the IOException there in a catch
block? Or just let it fall through?
> Inputstream not close after file read when loading regex filters in
> RegexURLFilter class
> ----------------------------------------------------------------------------------------
>
> Key: DROIDS-150
> URL: https://issues.apache.org/jira/browse/DROIDS-150
> Project: Droids
> Issue Type: Bug
> Components: core
> Affects Versions: Graduating from the Incubator
> Environment: All
> Reporter: Tony Dietrich
> Priority: Minor
> Labels: fix, patch
> Fix For: Graduating from the Incubator
>
> Attachments: RegexYRLFilter_diff.patch
>
>
> Inputstream not closed from RegexURLFilter after loading from classpath or
> disk file
> Patch attached
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
