[ https://jira.duraspace.org/browse/DS-640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18130#action_18130 ]
Sands Fish commented on DS-640: ------------------------------- Hi all. I wonder if this is the right choice, defaulting to a valid page if a robot/crawler uses an invalid URL. One comment Graham on the "given cause to process such a url" note. You may already know this so forgive me if I'm repeating what is already known, but as I understand it, Google actually morphs valid URLs to try and intuit or sniff out non-linked or missed URL-spaces for a domain. Shouldn't we appropriately return an error or at least 404 (or 400, see below) so these programmatic interactions understand that the URL should not be indexed or assumed to be valid in some way? (Forwarding to a valid browse page would be appropriate for human/interactive context, giving them some recourse, but this doesn't necessarily help in the case of a robot. Also, these malformed URLs are not coming from links within the DSpace instance, they are being created by a process external to DSpace.) The HTTP/1.1 spec suggests the following: 10.4.1 400 Bad Request The request could not be understood by the server due to malformed syntax. The client SHOULD NOT repeat the request without modifications. In our case, the correct response to the URL is not the browse index page, because it is not the content context it is explicitly requesting. Without appropriate parameters, this URL cannot create an "appropriate" response, and should, in line with the above 400 description, modify the request before it should expect an accurate response. (As an aside, if there is really opposition to an error response, I would think that redirecting to the item/comm/coll page, if the provided handle is valid, would be a more appropriate redirect, but I don't think that's the best course.) > Interal System Error when browsing with wrong argument > ------------------------------------------------------ > > Key: DS-640 > URL: https://jira.duraspace.org/browse/DS-640 > Project: DSpace > Issue Type: Bug > Components: JSPUI, XMLUI > Affects Versions: 1.5.2, 1.6.0, 1.6.1, 1.6.2 > Reporter: Hardik Mishra > Assignee: Kim Shepherd > Priority: Major > Attachments: browse.patch > > > On Browsing Items: > If someone tries to use browse type for which browse index does not exist, > like browse=publisher > e.g. http://dspace.webinito.com/browse?type > OR > e.g. http://dspace.webinito.com/browse?type=xyz > You will get Internal System Error -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.duraspace.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ------------------------------------------------------------------------------ Centralized Desktop Delivery: Dell and VMware Reference Architecture Simplifying enterprise desktop deployment and management using Dell EqualLogic storage and VMware View: A highly scalable, end-to-end client virtualization framework. Read more! http://p.sf.net/sfu/dell-eql-dev2dev _______________________________________________ Dspace-devel mailing list Dspace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspace-devel