[
https://jira.duraspace.org/browse/DS-640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18131#action_18131
]
Kim Shepherd commented on DS-640:
---------------------------------
OK well it sounds like we're still undecided on what this patch should actually
do and how /browse should work, what parameters are required, etc., so I won't
apply it.
We should probably bring this up at the next JIRA review and get another vote
on it.
My personal opinion is that we should throw 404s for invalid ?type= arguments
and a 400 for a missing or invalid query parameter (eg. empty /browse, invalid
/browse?nonexistent=foo), but that's assuming browse really does "require" an
index. I think Graham's "don't enforce ?type as required parameter, and default
to first browse index" idea has merit too, though it'd still end up throwing
500 in the case of an uninitialised index.
Most of the "how does Google treat query params" questions are dealt in the
original chat log, pasted in the first comment.
-k
> Interal System Error when browsing with wrong argument
> ------------------------------------------------------
>
> Key: DS-640
> URL: https://jira.duraspace.org/browse/DS-640
> Project: DSpace
> Issue Type: Bug
> Components: JSPUI, XMLUI
> Affects Versions: 1.5.2, 1.6.0, 1.6.1, 1.6.2
> Reporter: Hardik Mishra
> Assignee: Kim Shepherd
> Priority: Major
> Attachments: browse.patch
>
>
> On Browsing Items:
> If someone tries to use browse type for which browse index does not exist,
> like browse=publisher
> e.g. http://dspace.webinito.com/browse?type
> OR
> e.g. http://dspace.webinito.com/browse?type=xyz
> You will get Internal System Error
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.duraspace.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Centralized Desktop Delivery: Dell and VMware Reference Architecture
Simplifying enterprise desktop deployment and management using
Dell EqualLogic storage and VMware View: A highly scalable, end-to-end
client virtualization framework. Read more!
http://p.sf.net/sfu/dell-eql-dev2dev
_______________________________________________
Dspace-devel mailing list
Dspace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-devel
