[ 
https://jira.duraspace.org/browse/DS-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=25812#comment-25812
 ] 

DSpace @ Lyncode commented on DS-1172:
--------------------------------------

Ok. My point here is that, using Spring Roo generated entities, will represent 
a break on your previous work.
Our first attempts shown us:

Advantages:

- Intuitive API
- Good performance results

Disadvantages:

- Advanced queries requires the use of HQL (almost SQL)
- If such implementation was accepted it would require changing almost all 
DSpace code that queries the database (or at least, it must require).

Anyway, it's already working and it's easy to integrate with DSpace (as it 
already contains spring based services) - 
https://github.com/lyncode/dspace-data-layer/wiki/Code-Snippets.

Questions:

- Would it be fair to use such implementation?
- Would it be fair to keep the old database API and provide a new one? So it 
would be possible to achieve the same task progressively.
- Would it be fair to provide such API within dspace-api module? As a new 
module? As dspace-services module? Or as a new project (1)?

(1) I'm fan of this approach, mainly, because one could have distinct DSpace 
modules (within the main dspace bundle or not) using distinct versions of the 
ORM core bundle, basically it would be possible to go further and add more 
functionality to this dspace core bundle and, if needed, keep using older 
versions at the main bundle (maven configuration), with this, changes in this 
core bundle, would be more likely to be accepted as one wouldn't need to be 
worried with his dependencies.

Related:

https://wiki.duraspace.org/display/DSPACE/Refactoring+the+DSpace+Domain+Model
http://www.mail-archive.com/[email protected]/msg08796.html
                
> Add basic Spring based DAOs 
> ----------------------------
>
>                 Key: DS-1172
>                 URL: https://jira.duraspace.org/browse/DS-1172
>             Project: DSpace
>          Issue Type: Improvement
>            Reporter: Robin Taylor
>            Assignee: Robin Taylor
>
> A marker ticket for work being done to introduce DAOs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.duraspace.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to