Hi devs, I think I need some help. I'm trying to fix dvc, which gives me some trouble, but at this moment I have a very limited beginner's understanding of its internals (I hope you can help me to improve).
The current problem I tryed to fix: I pressed `y' from the `*baz-missing*' buffer to sync one of my trees and dvc yelled at me that nil failed arrayp. I edebugged `tla-revision-sync-tree' and found that --8<---------------cut here---------------start------------->8--- (tla--revision-revision (car (cddr elem))) --8<---------------cut here---------------end--------------->8--- failed. Ok, since `s' worked, I studied `tla-revision-star-merge' and found that in a very similar situation it calls --8<---------------cut here---------------start------------->8--- (tla--revision-revision (dvc-revlist-entry-patch-struct (nth 1 elem))) --8<---------------cut here---------------end--------------->8--- instead. Then I patched `tla-revision-sync-tree' mimicking `tla-revision-star-merge' and `y' worked (this is the enclosed patch). Out of curiosity, I poked around to see if there were other occurrences of this `(tla--revision-revision (car (cddr elem)))' thingy (or other similar in spirit forms) and found out that there are many, e.g., in `tla-revision-get-revision', `tla-revision-cache-revision', `tla-revision-add-to-library', `tla-revision-scroll-or-show-changeset', `tla-revision-delta', `tla-revision-bookmarks-add', `tla-revision-replay'. Now, of course, I wonder if: 1. my fix to `tla-revision-sync-tree' is right; 2. I should fix the same way other similar occurrences in `tla.el'. Can you please help me, if nothing else just to tell me whether I'm completely out of track? <<LOG-START>> Fix tla-revision-sync-tree drawing from tla-revision-star-merge. <<LOG-END>> [VERSION] [EMAIL PROTECTED]/dvc--main--0--patch-7 Emacs : GNU Emacs 22.0.50.1 (i486-pc-linux-gnu, GTK+ Version 2.8.17) of 2006-05-24 on pacem, modified by Debian -- Thanks, Davide
++arch-patch-2006-06-03_18-04-06.tar.gz
Description: Binary data
_______________________________________________ Dvc-dev mailing list [email protected] https://mail.gna.org/listinfo/dvc-dev
