Hello list,
sorry about this delay but I can only work of DVC at weekends...

2007/6/10, Stefan Reichör <[EMAIL PROTECTED]>:
Committed revision 188 to http://bzr.xsteve.at/dvc/

Miscellaneous compatibility and regexp fixes

  Patch from Michael Olson <[EMAIL PROTECTED]>
  * lisp/xgit-annotate.el (xgit-annotate-font-lock-keywords)

For xgit-annotate-font-lock-keywords the code does not use it now.
I left it there by my mistake in the first commit.
I deleted it in the following patch.

    (xgit-info-to-allbutlinenum, xgit-annotate-revision-regexp)
    (xgit-annotate-show-rev): Use "\\s" instead of "\s" and "^" instead of
    "^^?" and "^^".

For the fix in regular expressions in xgit-annoate-info-regexp, which
changed \s to \\s, the original version was correct.

I meant \s as "space or tabs" in regular expression.
Maybe using \s is obsolete or not appropriate?
I replaced them by [[:blank:]] for clearity in the following patch.

And for the xgit-annotate-revision-regexp fix, which removed second ^ in
   "^^?\\([[:xdigit:]]+\\)"  (original),
this needs to be reversed as git-blame (annotate command in git)
shows the first revision hash id with "^" prepended.

   e.g.
       "^de398cf (Takuzo Ohara 2007-02-21 21:28:35 +0900 366) ..."

I also fixed to use xgit-annotate-revision-regexp in xgit-annotate-show-rev.

    (_xgit-annotate-hide-revinfo): Pass 1 to `previous-line' for Emacs21
    compatibility.

  * lisp/xgit.el (xgit-annotate): Use `dvc-line-number-at-pos' instead of
    `line-number-at-pos'.

Thank you for the fix.
I can learn a lot from DVC code and this list.

Attachment: xgit-annotate-re-fix.patch
Description: Binary data

_______________________________________________
Dvc-dev mailing list
[email protected]
https://mail.gna.org/listinfo/dvc-dev

Reply via email to