Hi Thi Thien-Thi Nguyen <[EMAIL PROTECTED]> writes: > As a janitor, it irks me when mopping the floor in one room slops > water into the hallway, whether it be clean or dirty. WRT DVC > config/build concerns, this translates to config/build having side > effects outside the build tree. > > The particular instance (that still to date prevents me from > building and actually using DVC due to the above annoyance) in > question is in lisp/dvc-bookmarks.el, line 266, which reads: > > (set-dvc-bookmarks-cache) > > The config process doesn't bother with this file, so no complaints > there. The build process, on the other hand, loads it at some > point, thus evaluating that line. Tracing the evaluation when i > do "make" at top-level, i see that it fails because directory > ~/.dvc does not exist, `(find-file dvc-bookmarks-prop-file)' does > not error out but instead creates a read-only buffer, which a few > lines later, causes `insert' to signal "buffer is read only". > That is, the buffer *compilation* ends with the lines (sans pipe): > > |Loading /home/ttn/build/MISC/dvc/lisp/bzr-revlog.el (source)... > |Loading /home/ttn/build/MISC/dvc/lisp/bzr-submit.el (source)... > |Loading /home/ttn/build/MISC/dvc/lisp/bzr.el (source)... > |Loading /home/ttn/build/MISC/dvc/lisp/dvc-about.el (source)... > |Loading /home/ttn/build/MISC/dvc/lisp/dvc-annotate.el (source)... > |Loading /home/ttn/build/MISC/dvc/lisp/dvc-be.el (source)... > |Loading /home/ttn/build/MISC/dvc/lisp/dvc-bookmarks.el (source)... > |Buffer is read-only: #<buffer dvc-bookmarks-properties.el> > |make[1]: *** [clean-some] Error 255 > |make: *** [dvc] Error 2 > > If we "fix" `set-dvc-bookmarks-cache' to either handle missing > ~/.dvc itself with `make-directory', or (better yet), to use > dvc-config.el facilities, then that still leaves the irksome > problem that "make" modifies my home directory. > > So i suggest we: > 1/ make `set-dvc-bookmarks-cache' use dvc-config.el; > 2/ move that line elsewhere, or even nowhere (if possible); > 3/ look for other instances of config- or build-time > out-of-tree munging and eliminate them. > > WDYT? (In particular, insight into 2/ and 3/ most welcome.)
If you move this line elsewhere, it would try to load the content of dvc-bookmarks-prop-file inside the hash-table before creating this one. Waiting a fix, you can try to : ,---- | mkdir ~/.dvc | touch ~/.dvc/dvc-bookmarks-properties.el `---- After building dvc, remove the file before reloading dvc. (dvc will create the file again with the right header) I will look tomorrow what i can do to avoid that. -- A + Thierry Volpiatto Location: Saint-Cyr-Sur-Mer - France _______________________________________________ Dvc-dev mailing list [email protected] https://mail.gna.org/listinfo/dvc-dev
