Stephen Leake <[EMAIL PROTECTED]> writes:
> Michael Olson <[EMAIL PROTECTED]> writes:
>
>> Thien-Thi Nguyen <[EMAIL PROTECTED]> writes:
>>
>>> So i suggest we:
>>> 1/ make `set-dvc-bookmarks-cache' use dvc-config.el;
>>> 2/ move that line elsewhere, or even nowhere (if possible);
>>> 3/ look for other instances of config- or build-time
>>> out-of-tree munging and eliminate them.
>>>
>>> WDYT? (In particular, insight into 2/ and 3/ most welcome.)
>>
>> I vote for 2 and 3. Modifying the homedir during build process is a
>> nonstarter.
>
> +1
It' fixed now in this patch.
# HG changeset patch
# User Thierry Volpiatto <[EMAIL PROTECTED]>
# Date 1215758691 -7200
# Node ID 1a258772b1347f69f6402cbb114b3018e818b8e2
# Parent 62a995b4dee24796cf858af652256a69375f32fd
"Fix load of hash-table at build time"
diff --git a/lisp/dvc-bookmarks.el b/lisp/dvc-bookmarks.el
--- a/lisp/dvc-bookmarks.el
+++ b/lisp/dvc-bookmarks.el
@@ -263,7 +263,7 @@
(save-buffer)
(quit-window))))
-(set-dvc-bookmarks-cache)
+;;(set-dvc-bookmarks-cache)
(defmacro hash-get-items (hash-table)
"Get the list of all keys/values of hash-table
@@ -516,6 +516,8 @@
With prefix argument ARG, reload the bookmarks file from disk."
(interactive "P")
(dvc-bookmarks-load-from-file arg)
+ (when (eq (hash-table-count dvc-bookmarks-cache) 0)
+ (set-dvc-bookmarks-cache))
(dvc-switch-to-buffer (get-buffer-create "*dvc-bookmarks*"))
(let ((cur-pos (point)))
(toggle-read-only 0)
--
A + Thierry Volpiatto
Location: Saint-Cyr-Sur-Mer - France
_______________________________________________
Dvc-dev mailing list
[email protected]
https://mail.gna.org/listinfo/dvc-dev
