Hello dvdnav list,
While trying to play a recent movie VLC segfaulted when describing title
chapters.

Looking at the backtrace it seem that a cell is simply returned empty,
but there is no check and it is dereferenced, thus causing the segfualt.

The attached, simple, patch fixes my issue by skipping empty cells.

I still don't know if it causes any side effect as I haven't watched the
whole movie yet, but by skipping through it seemed all ok.

(I am not subscribed, so please keep me in CC if you need to ask me anything)

Simo.

diff --git a/src/searching.c b/src/searching.c
index 66f7adb..31bf0d3 100644
--- a/src/searching.c
+++ b/src/searching.c
@@ -628,6 +628,7 @@ uint32_t dvdnav_describe_title_chapters(dvdnav_t *this, int32_t title, uint64_t
     else
       endcellnr = 0;
 
+    if (!pgc->cell_playback) continue;
     do {
       cell = &pgc->cell_playback[cellnr-1];
       if(!(cell->block_type == BLOCK_TYPE_ANGLE_BLOCK &&
_______________________________________________
DVDnav-discuss mailing list
[email protected]
https://lists.mplayerhq.hu/mailman/listinfo/dvdnav-discuss

Reply via email to