On Tue, Feb 10, 2009 at 8:35 AM, Andre Detsch <adet...@br.ibm.com> wrote: > > When running ethtool -t on an interface that was just > brought down, the link test was failing. That's because > we need to perform a reset on the interface to be able > to check the link status correctly. There is no problem > on doing such reset right before the test, as the link > test routine is prepared to wait for autoneg to complete > if that is the case. > > Signed-off-by: Andre Detsch <adet...@br.ibm.com> > ---
I guess this comes down to what the definition of a Link test should be doing. My $0.02 is that it should be testing if the interface has a link, in which case if you ifdown the interface before running the Link test, I would expect it to fail. With this patch, if you bring down the device and run the ethtool diag tests, the Link test would come back as passing which is something I would not expect. NAK. -- Cheers, Jeff ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel
