when using DMAPOOL_DEBUG, do we really want to over-write memset(retval, POOL_POISON_ALLOCATED, pool->size); set in dma_pool_alloc.
On Thu, Dec 17, 2009 at 9:21 AM, Brandeburg, Jesse <[email protected]> wrote: > > On Thu, 17 Dec 2009, Roger Oksanen wrote: >> e100: Fix broken cbs accounting due to missing memset. >> >> Alan Stern noticed that e100 caused slab corruption. >> commit 98468efddb101f8a29af974101c17ba513b07be1 changed >> the allocation of cbs to use dma pools that don't return zeroed memory, >> especially the cb->status field used to track which cb to clean, causing >> (the visible) double freeing of skbs and a wrong free cbs count. >> >> Now the cbs are explicitly zeroed at allocation time. >> >> Reported-by: Alan Stern <[email protected]> >> Tested-by: Alan Stern <[email protected]> >> Signed-off-by: Roger Oksanen <[email protected]> > > Change looks reasonable, ACK. > > should we also consider a followon patch to zero memory allocated with > pci_pools? Seems useful. > > Acked-by: Jesse Brandeburg <[email protected]> > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html > ------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel
