From: "Brandeburg, Jesse" <[email protected]> Date: Thu, 17 Dec 2009 09:21:49 -0800 (Pacific Standard Time)
> > On Thu, 17 Dec 2009, Roger Oksanen wrote: >> e100: Fix broken cbs accounting due to missing memset. >> >> Alan Stern noticed that e100 caused slab corruption. >> commit 98468efddb101f8a29af974101c17ba513b07be1 changed >> the allocation of cbs to use dma pools that don't return zeroed memory, >> especially the cb->status field used to track which cb to clean, causing >> (the visible) double freeing of skbs and a wrong free cbs count. >> >> Now the cbs are explicitly zeroed at allocation time. >> >> Reported-by: Alan Stern <[email protected]> >> Tested-by: Alan Stern <[email protected]> >> Signed-off-by: Roger Oksanen <[email protected]> > > Change looks reasonable, ACK. Applied, thanks everyone. I'll try to requeue the e100 stuff together into -stable again now that this is resolved. > should we also consider a followon patch to zero memory allocated with > pci_pools? Seems useful. Nah, it's more fun debugging subtle bugs like this one. :-) ------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel
