On Mon, Nov 01, 2010 at 09:05:25PM +0000, Ben Hutchings wrote: > [...] > > My proposal is to implement a offload feature setting that needs > > (almost) no code in network driver. The idea is to add two > > ethtool-specific fields to struct net_device: > > > > - hw_features > > offloads supported by the netdev (togglable by user) > > - features_requested > > offloads currently requested by user; this will be superset of > > (features & hw_features) when i.e. current MTU or other external > > conditions disable some offloads > > > > ... and use them to implement changing of offloads in ethtool core. > > Since get_*() for TX offloads is just a bit test on netdev->features, > > corresponding ethtool entry points could be removed. > > Right. > > It also might be worth defining a standard feature flag for RX checksum > offload, since currently every driver has to maintain its own private > flag. Though we're running short of feature flags on 32-bit machines.
RX offloads are different in that most devices allow readback of configured bits, so actually no specific flags are needed. I've postponed thinking about this until after I cleaning up TX part. > [...] > > * sfc > > assumed: constant efx->type->offload_features > [...] > > This is correct. Thanks, Michał Mirosław ------------------------------------------------------------------------------ Nokia and AT&T present the 2010 Calling All Innovators-North America contest Create new apps & games for the Nokia N8 for consumers in U.S. and Canada $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store http://p.sf.net/sfu/nokia-dev2dev _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
