On Tue, Nov 02, 2010 at 01:14:23AM +0000, Ben Hutchings wrote: > Michał Mirosław wrote: > > On Mon, Nov 01, 2010 at 09:05:25PM +0000, Ben Hutchings wrote: > [...] > > > It also might be worth defining a standard feature flag for RX checksum > > > offload, since currently every driver has to maintain its own private > > > flag. Though we're running short of feature flags on 32-bit machines. > > RX offloads are different in that most devices allow readback of > > configured bits, so actually no specific flags are needed. > [...] > Most devices also need resetting from time to time, so those flags still > need to be included in software state.
Ah. Good point. So this should be converted to the same way the TX offloads will be handled. Is it worth to split rx and tx features to separate bitfields? Especially that we're running out of bits in u32 and that TX flags are used in hot path and RX are normally not accessed much. Are the features flags exported somewhere to userspace except via ethtool? Best Regards, Michał Mirosław ------------------------------------------------------------------------------ Nokia and AT&T present the 2010 Calling All Innovators-North America contest Create new apps & games for the Nokia N8 for consumers in U.S. and Canada $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store http://p.sf.net/sfu/nokia-dev2dev _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
