oups, the previous mail was send incomplete...
Hi,
Selon [EMAIL PROTECTED]:
>
> Always eagleusb/driver/user/eaglectrl.c
>
> /*
> * FIXME: Add a check on the type of message. Currently in last version
> * furnished by ADI there are: optn, mask, diag, flag, cntl
> *
> */
>
I think the check could be done in kernelspace with eu_check_symb_addr that was
remove for incomming cmvs.
Anyway if eu_check_symb_addr is removed, why don't remove symb_addresses table?
Since I talk about eu_msg.c, why not clearing all the unsued Msg ? I would make
the code more readable.
Also in eu_decode_msg the subid checking is a bit strange :
Something like
switch(msg->subtype) {
case SUBTYPE_FLASHACC_ENMODEMREBOOTREPLY ... SUBTYPE_FLASHACC_READREPLY:
if (msg->type != MP_FUNCTION_TYPE_FLASHACC) {
error
}
case ...
would be a bit cleaner.
When the cmv works correctly, will all the option code in eu_msg.c will be
removed (including linetype) ?
The option file will stay only with atm config (RatePollFreq seem unsued) ?
Matthieu
