Another ignore candidate. We use the following mock object pattern:

---
public class MockAccount implements Account {

     public boolean getAccountIdCalled;
     public java.lang.String getAccountIdReturn;
     public java.lang.String getAccountId() {
         getAccountIdCalled = true;
         return getAccountIdReturn;
     }

     public boolean getTypeCalled;
     public com.its.trading.domain.account.AccountType getTypeReturn;
     public com.its.trading.domain.account.AccountType getType() {
         getTypeCalled = true;
         return getTypeReturn;
     }
}
---

Idea says that the public variables could be private, but they are used 
many tests. Sure we could have created accessors, but for mocks that 
seems a bit overkill. But why would idea say they could be private if 
they are actually being used? I could see a sugestion to add accesors 
(which I would then want to be exluded for mocks).

_______________________________________________
Eap-features mailing list
[EMAIL PROTECTED]
http://lists.jetbrains.com/mailman/listinfo/eap-features

Reply via email to