Branch: refs/heads/master
  Home:   https://github.com/tianocore/edk2
  Commit: 43e86ce5d5fcca1c4b6b45067ccd8a6cfab0e2b5
      
https://github.com/tianocore/edk2/commit/43e86ce5d5fcca1c4b6b45067ccd8a6cfab0e2b5
  Author: Michael Kubacki <[email protected]>
  Date:   2025-12-01 (Mon, 01 Dec 2025)

  Changed paths:
    M .github/scripts/GitHub.py

  Log Message:
  -----------
  .github/scripts: Make reviewer filtering case insensitive

The `add_reviewers_to_pr()` function in GitHub.py did not compare
all usernames without case sensitivity which could cause a reviewer
that has already reviewed a pull request to be re-requested.

The occurred under the following conditions:

- GetMaintainer.py returns usernames from Maintainers.txt
  (e.g. "user")
- GitHub API returns usernames in their actual case (e.g. "User")
- The exclusion filter used case-sensitive comparison so the match
  is not detected

Fixed by converting the exclusion set to lowercase and performing
case-insensitive comparison when filtering for new reviewers.

Signed-off-by: Michael Kubacki <[email protected]>



To unsubscribe from these emails, change your notification settings at 
https://github.com/tianocore/edk2/settings/notifications


_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits

Reply via email to