David, This patch series should be based on the old version, before the back-porting of upstreaming patch was done. We should have no need to add the extra patches on OpenSSL now for OpensslTlsLib build now.
Best Regards & Thanks, LONG, Qin > -----Original Message----- > From: David Woodhouse [mailto:dw...@infradead.org] > Sent: Thursday, March 10, 2016 2:47 AM > To: Wu, Jiaxin <jiaxin...@intel.com>; edk2-de...@ml01.01.org > Cc: Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Long, Qin > <qin.l...@intel.com> > Subject: Re: [edk2] [Patch 2/6] CryptoPkg: Add OpensslTlsLib module to enable > 'openssl\ssl' > > On Wed, 2016-02-24 at 16:15 +0800, Jiaxin Wu wrote: > > diff --git a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c > > b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c > > index c0ccc0e..e68bfb8 100644 > > --- a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c > > +++ b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c > > @@ -446,5 +446,10 @@ void syslog (int a, const char *c, ...) > > > > ssize_t write (int f, const void *b, size_t l) > > { > > return 0; > > } > > + > > +int printf (char const *fmt, ...) > > +{ > > + return 0; > > +} > > I'm assuming this is to work around a stray printf() in OpenSSL code > that we weren't building before? > > The correct fix is to file a ticket upstream, submit a *fix* upstream > to be included in OpenSSL, and then to add the corresponding backported > patch to our EDKII_openssl patch. > > Please don't add more workarounds like the above; we're trying to clean > those up not accumulate more. > > And again... even if this was the right thing to do, it lives in a > *separate* standalone commit. It's OK if it's gratuitous, and the > commit comment simply says "we *will* want this because...". > > See some of the OpenSSL API cleanups, for example, which make things > *ready* for OpenSSL 1.1 even while we're still using 1.0.2. > > -- > David Woodhouse Open Source Technology Centre > david.woodho...@intel.com Intel Corporation _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
