Leroy, The QuarkSocPkg does not support 64-bit. The DSC file for that package only lists IA32.
I agree that protocol services need to be EFIAPI, so please update commit message so the reason for the change is to add missing EFIAPI for a protocol service. Thanks, Mike > -----Original Message----- > From: Leahy, Leroy P > Sent: Wednesday, May 11, 2016 4:09 PM > To: [email protected]; Leahy, Leroy P <[email protected]>; Kinney, > Michael D <[email protected]>; Steele, Kelly <[email protected]> > Subject: [PATCH 3/3] QuarkSocPkg/SDControllerDxe: Add EFIAPI to > SetHighSpeedMode > > Fix 64-bit build error detected with GCC4.8 due to inconsistent routine > declaration and implementation. Add EFIAPI to fix the build error. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Lee Leahy <[email protected]> > --- > QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDControllerDxe/SDController.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git > a/QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDControllerDxe/SDController.c > b/QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDControllerDxe/SDController.c > index 18e85c8..2b5dbe6 100644 > --- a/QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDControllerDxe/SDController.c > +++ b/QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDControllerDxe/SDController.c > @@ -244,6 +244,7 @@ GetErrorReason ( > @return EFI_SUCCESS > **/ > EFI_STATUS > +EFIAPI > SetHighSpeedMode ( > IN EFI_SD_HOST_IO_PROTOCOL *This, > IN BOOLEAN Enable > -- > 1.9.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
