Reviewed-by: Michael Kinney <[email protected]> Mike
> -----Original Message----- > From: Leahy, Leroy P > Sent: Wednesday, May 11, 2016 4:08 PM > To: [email protected]; Leahy, Leroy P <[email protected]>; Kinney, > Michael D <[email protected]>; Steele, Kelly <[email protected]> > Subject: [PATCH 1/3] QuarkPlatformPkg: Fix build errors > > Fix build errors detected with GCC 4.8.4: local variable set but not > used! > > Change-Id: I5e3cfb46b367a72bd333fd762c22968fbac4e6f9 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Lee Leahy <[email protected]> > --- > QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPciUpdate.c | 2 -- > QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPlatform.c | 4 ---- > .../Dxe/SmbiosMiscDxe/MiscNumberOfInstallableLanguagesFunction.c | 4 +--- > QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscOemStringFunction.c | 3 --- > .../Platform/Dxe/SmbiosMiscDxe/MiscSystemOptionStringFunction.c | 3 --- > QuarkPlatformPkg/Platform/Pei/PlatformInit/Generic/Recovery.c | 6 > ------ > QuarkPlatformPkg/Platform/Pei/PlatformInit/MrcWrapper.c | 5 +---- > 7 files changed, 2 insertions(+), 25 deletions(-) > > diff --git a/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPciUpdate.c > b/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPciUpdate.c > index b0f0b44..653df45 100644 > --- a/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPciUpdate.c > +++ b/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPciUpdate.c > @@ -261,9 +261,7 @@ SdtGetNameStringSize ( > { > UINTN SegCount; > UINTN Length; > - UINT8 *Name; > > - Name = Buffer; > Length = 0; > > // > diff --git a/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPlatform.c > b/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPlatform.c > index aa18cae..f085753 100644 > --- a/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPlatform.c > +++ b/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPlatform.c > @@ -255,7 +255,6 @@ ApicTableUpdate ( > UINT8 CurrProcessor; > UINTN NumberOfCPUs; > UINTN NumberOfEnabledCPUs; > - UINTN BufferSize; > EFI_PROCESSOR_INFORMATION MpContext; > ACPI_APIC_STRUCTURE_PTR *ApicPtr; > > @@ -298,7 +297,6 @@ ApicTableUpdate ( > switch (ApicPtr->AcpiApicCommon.Type) { > > case EFI_ACPI_1_0_PROCESSOR_LOCAL_APIC: > - BufferSize = sizeof (EFI_PROCESSOR_INFORMATION); > ApicPtr->AcpiLocalApic.Flags = 0; > ApicPtr->AcpiLocalApic.ApicId = 0; > Status = MpService->GetProcessorInfo ( > @@ -562,7 +560,6 @@ AcpiPlatformEntryPoint ( > UINT32 FvStatus; > UINTN Size; > EFI_ACPI_TABLE_VERSION Version; > - QNC_DEVICE_ENABLES QNCDeviceEnables; > EFI_HANDLE Handle; > UINTN Index; > PCI_DEVICE_INFO *PciDeviceInfo; > @@ -577,7 +574,6 @@ AcpiPlatformEntryPoint ( > TableHandle = 0; > CurrentTable = NULL; > mConfigData = NULL; > - QNCDeviceEnables.Uint32 = PcdGet32 (PcdDeviceEnables); > > // > // Initialize the EFI Driver Library > diff --git > a/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscNumberOfInstallableLanguagesFunctio > n.c > b/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscNumberOfInstallableLanguagesFunctio > n.c > index d17f5ea..48c2d53 100644 > --- > a/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscNumberOfInstallableLanguagesFunctio > n.c > +++ > b/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscNumberOfInstallableLanguagesFunctio > n.c > @@ -190,7 +190,6 @@ MISC_SMBIOS_TABLE_FUNCTION(NumberOfInstallableLanguages) > CHAR8 > CurrentLang[SMBIOS_STRING_MAX_LENGTH + > 1]; > CHAR8 *OptionalStrStart; > UINT16 Offset; > - BOOLEAN LangMatch; > EFI_STATUS Status; > EFI_SMBIOS_HANDLE SmbiosHandle; > SMBIOS_TABLE_TYPE13 *SmbiosRecord; > @@ -210,9 +209,8 @@ MISC_SMBIOS_TABLE_FUNCTION(NumberOfInstallableLanguages) > // > // Try to check if current langcode matches with the langcodes in installed > languages > // > - LangMatch = FALSE; > ZeroMem(CurrentLang, SMBIOS_STRING_MAX_LENGTH + 1); > - LangMatch = CurrentLanguageMatch (mHiiHandle, &Offset, CurrentLang); > + CurrentLanguageMatch (mHiiHandle, &Offset, CurrentLang); > LangStrLen = AsciiStrLen(CurrentLang); > > // > diff --git > a/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscOemStringFunction.c > b/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscOemStringFunction.c > index e352000..af6df02 100644 > --- a/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscOemStringFunction.c > +++ b/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscOemStringFunction.c > @@ -38,9 +38,6 @@ MISC_SMBIOS_TABLE_FUNCTION(MiscOemString) > STRING_REF TokenToGet; > EFI_SMBIOS_HANDLE SmbiosHandle; > SMBIOS_TABLE_TYPE11 *SmbiosRecord; > - EFI_MISC_OEM_STRING *ForType11InputData; > - > - ForType11InputData = (EFI_MISC_OEM_STRING *)RecordData; > > // > // First check for invalid parameters. > diff --git > a/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscSystemOptionStringFunction.c > b/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscSystemOptionStringFunction.c > index 44cc684..52021d8 100644 > --- > a/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscSystemOptionStringFunction.c > +++ > b/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/MiscSystemOptionStringFunction.c > @@ -40,9 +40,6 @@ MISC_SMBIOS_TABLE_FUNCTION(SystemOptionString) > STRING_REF TokenToGet; > EFI_SMBIOS_HANDLE SmbiosHandle; > SMBIOS_TABLE_TYPE12 *SmbiosRecord; > - EFI_MISC_SYSTEM_OPTION_STRING *ForType12InputData; > - > - ForType12InputData = (EFI_MISC_SYSTEM_OPTION_STRING *)RecordData; > > // > // First check for invalid parameters. > diff --git a/QuarkPlatformPkg/Platform/Pei/PlatformInit/Generic/Recovery.c > b/QuarkPlatformPkg/Platform/Pei/PlatformInit/Generic/Recovery.c > index ea67ba9..86c98f7 100644 > --- a/QuarkPlatformPkg/Platform/Pei/PlatformInit/Generic/Recovery.c > +++ b/QuarkPlatformPkg/Platform/Pei/PlatformInit/Generic/Recovery.c > @@ -137,26 +137,21 @@ Returns: > UINTN NumberRecoveryCapsules; > UINTN RecoveryCapsuleSize; > EFI_GUID DeviceId; > - BOOLEAN ImageFound; > EFI_PHYSICAL_ADDRESS Address; > VOID *Buffer; > EFI_CAPSULE_HEADER *CapsuleHeader; > EFI_PEI_HOB_POINTERS Hob; > - EFI_PEI_HOB_POINTERS HobOld; > BOOLEAN HobUpdate; > EFI_FIRMWARE_VOLUME_HEADER *FvHeader; > UINTN Index; > - EFI_STATUS AuthStatus; > EFI_GUID mEfiCapsuleHeaderGuid = > QUARK_CAPSULE_GUID; > > Index = 0; > > Status = EFI_SUCCESS; > - AuthStatus = EFI_SUCCESS; > HobUpdate = FALSE; > > ProviderAvailable = TRUE; > - ImageFound = FALSE; > NumberOfImageProviders = 0; > > DeviceRecoveryModule = NULL; > @@ -284,7 +279,6 @@ Returns: > // > Buffer = (VOID *)((UINT8 *) Buffer); > Status = PeiServicesGetHobList ((VOID **)&Hob.Raw); > - HobOld.Raw = Hob.Raw; > while (!END_OF_HOB_LIST (Hob)) { > if (Hob.Header->HobType == EFI_HOB_TYPE_FV) { > DEBUG ((EFI_D_INFO | EFI_D_LOAD, "Hob FV Length: %x\n", > Hob.FirmwareVolume- > >Length)); > diff --git a/QuarkPlatformPkg/Platform/Pei/PlatformInit/MrcWrapper.c > b/QuarkPlatformPkg/Platform/Pei/PlatformInit/MrcWrapper.c > index 70c9cf9..df6c1cc 100644 > --- a/QuarkPlatformPkg/Platform/Pei/PlatformInit/MrcWrapper.c > +++ b/QuarkPlatformPkg/Platform/Pei/PlatformInit/MrcWrapper.c > @@ -1089,7 +1089,6 @@ RetriveRequiredMemorySize ( > OUT UINTN *Size > ) > { > - EFI_STATUS Status; > EFI_PEI_HOB_POINTERS Hob; > EFI_MEMORY_TYPE_INFORMATION *MemoryData; > UINT8 Index; > @@ -1099,7 +1098,7 @@ RetriveRequiredMemorySize ( > TempPageNum = 0; > Index = 0; > > - Status = PeiServicesGetHobList ((VOID **)&Hob.Raw); > + PeiServicesGetHobList ((VOID **)&Hob.Raw); > while (!END_OF_HOB_LIST (Hob)) { > if (Hob.Header->HobType == EFI_HOB_TYPE_GUID_EXTENSION && > CompareGuid (&Hob.Guid->Name, &gEfiMemoryTypeInformationGuid) > @@ -1171,7 +1170,6 @@ GetMemoryMap ( > PEI_MEMORY_RANGE_SMRAM SmramMask; > PEI_MEMORY_RANGE_SMRAM TsegMask; > UINT32 BlockNum; > - UINT8 EsmramcRegister; > UINT8 ExtendedMemoryIndex; > UINT32 Register; > > @@ -1194,7 +1192,6 @@ GetMemoryMap ( > // > // Generate Memory ranges for the memory map. > // > - EsmramcRegister = 0; > MemorySize = 0; > > RowLength = TotalMemorySize; > -- > 1.9.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
