> -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: 05 June 2017 16:40 > To: Scott Telford <stelf...@cadence.com> > Cc: edk2-devel@lists.01.org <edk2-de...@ml01.01.org>; Leif Lindholm > <leif.lindh...@linaro.org>; Graeme Gregory <graeme.greg...@linaro.org>; > af...@apple.com; Kinney, Michael D <michael.d.kin...@intel.com> > Subject: Re: [staging/cadence-aarch64 PATCH v2 5/6] CadencePkg: Add ACPI > tables for Cadence CSP platform. >
> > > + Device (LNKA) > > + { > > + Name (_HID, Eisaid ("PNP0C0F")) > > + Name (_UID, 1) > > + Name(_PRS, ResourceTemplate(){ > > + Interrupt(ResourceProducer, Level, ActiveHigh, Exclusive, , ,) { > > 46 } > > + }) > > + Method(_DIS) {} > > + Method(_CRS) { Return (_PRS) } > > + Method(_SRS, 1) {} > > + } > > + Device (LNKB) > > + { > > + Name (_HID, Eisaid ("PNP0C0F")) > > + Name (_UID, 1) > > + Name(_PRS, ResourceTemplate(){ > > + Interrupt(ResourceProducer, Level, ActiveHigh, Exclusive, , ,) { > > 46 } > > + }) > > + Method(_DIS) {} > > + Method(_CRS) { Return (_PRS) } > > + Method(_SRS, 1) {} > > + } > > + Device (LNKC) > > + { > > + Name (_HID, Eisaid ("PNP0C0F")) > > + Name (_UID, 1) > > + Name(_PRS, ResourceTemplate(){ > > + Interrupt(ResourceProducer, Level, ActiveHigh, Exclusive, , ,) { > > 46 } > > + }) > > + Method(_DIS) {} > > + Method(_CRS) { Return (_PRS) } > > + Method(_SRS, 1) {} > > + } > > + Device (LNKD) > > + { > > + Name (_HID, Eisaid ("PNP0C0F")) > > + Name (_UID, 1) > > + Name(_PRS, ResourceTemplate(){ > > + Interrupt(ResourceProducer, Level, ActiveHigh, Exclusive, , ,) { > > 46 } > > + }) > > + Method(_DIS) {} > > + Method(_CRS) { Return (_PRS) } > > + Method(_SRS, 1) {} > > + } > > + > > This looks like a very complicated way (combined with the _PRT below) > to route all legacy interrupts to GSIV 46. You can fold this into _PRT > instead AFAIK This is actually very similar to the example code in section 6.2.13.1 of the ACPI 6.0 spec. Regards, Scott. _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel