2017-06-30 21:29 GMT+08:00 Gao, Liming <liming....@intel.com>: > Jun: > You can add C MACRO in [BuildOptions] of Platform.dsc, then use DSC flag to > control it. > > For example: Platform.dsc > [Defines] > DEFINE ZX_PL011_FLAG = FALSE > > [BuildOptions] > !if $(ZX_PL011_FLAG) == TRUE > *_*_*_CC_FLAGS = -D ZX_PL011_FLAG > !endif > > Thanks > Liming
Thanks for your demo code. It help a lot to a new comer. Jun >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jun >> Nie >> Sent: Friday, June 30, 2017 11:35 AM >> To: Leif Lindholm <leif.lindh...@linaro.org>; Ard Biesheuvel >> <ard.biesheu...@linaro.org>; edk2-devel@lists.01.org; >> linaro-u...@lists.linaro.org; alexei.fedo...@arm.com; evan.ll...@arm.com >> Subject: [edk2] How to add support to different reg offset definition to >> share the same driver code? >> >> Hi, >> >> I am trying to add support to different reg offset and bit offset in >> PL011 UART. It seems impossible to add macro in platform.dsc to enable >> undef/redef in the header file with "#ifdef ZX_PL011_FLAG". Is there >> any proper way to control the reg/bit offset definition? Or we have to >> adopt the Linux driver method with a structure to hold different >> offset value and wrap register access function as below? If so, >> another Pcd is needed to specify the offset structure index for the >> platforms. >> >> >> static u16 pl011_st_offsets[REG_ARRAY_SIZE] = { >> [REG_DR] = UART01x_DR, >> [REG_ST_DMAWM] = ST_UART011_DMAWM, >> [REG_ST_TIMEOUT] = ST_UART011_TIMEOUT, >> ... >> } >> >> static unsigned int pl011_read(const struct uart_amba_port *uap, >> unsigned int reg) >> { >> void __iomem *addr = uap->port.membase + uap->reg_offset[reg]; >> >> return (uap->port.iotype == UPIO_MEM32) ? >> readl_relaxed(addr) : readw_relaxed(addr); >> } >> >> Jun >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
