Thanks for the feedback. I'll change the patch order in v4.
> -----Original Message----- > From: Zeng, Star > Sent: Thursday, October 26, 2017 2:53 PM > To: Yao, Jiewen <jiewen....@intel.com>; Wang, Jian J <jian.j.w...@intel.com>; > edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Wolman, Ayellet > <ayellet.wol...@intel.com>; Dong, Eric <eric.d...@intel.com>; Zeng, Star > <star.z...@intel.com> > Subject: RE: [edk2] [PATCH v3 0/6] Implement heap guard feature > > I suggest putting [3/6] at the first patch as it adds definitions that are > used by > other patches. > > Thanks, > Star > -----Original Message----- > From: Yao, Jiewen > Sent: Thursday, October 26, 2017 2:49 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Wolman, Ayellet > <ayellet.wol...@intel.com>; Dong, Eric <eric.d...@intel.com>; Zeng, Star > <star.z...@intel.com>; Yao, Jiewen <jiewen....@intel.com> > Subject: RE: [edk2] [PATCH v3 0/6] Implement heap guard feature > > That is great work. Jian. > > Some suggestion for your consideration: > > 0) I suggest add Laszlo to review SMM part, and add Ruiyu to review > SMM_MEMORY_ATTRIBUTE_PROTOCOL. > > 1) Would you please mention what test we have done for this feature? > Such as OVMF/realPlatform? IA32/X64? > > Have you validated NT32? Or try to enable protection? :-) > > 2) Is that any dependency of this patch? > I think there is OPENSSL wrapper reallocate() issue not resolved yet. > > I suggest we check in all dependent patch at first, then check in this one. > > 3) If you need submit V4, please separate > MdeModulePkg/Include/Protocol/SmmMemoryAttribute.h from 2/6 to be a > standalone patch. In general, an interface and an implementation are > separated. > > > Thank you > Yao Jiewen > > > > > -----Original Message----- > > From: Wang, Jian J > > Sent: Wednesday, October 25, 2017 9:48 AM > > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Wolman, Ayellet > > <ayellet.wol...@intel.com>; Yao, Jiewen <jiewen....@intel.com>; Dong, > > Eric <eric.d...@intel.com>; Zeng, Star <star.z...@intel.com> > > Subject: RE: [edk2] [PATCH v3 0/6] Implement heap guard feature > > > > Hi, > > > > Just a warm reminding. I didn't see any feedbacks on the v3 patch. > > If no more comments, I'll check in the patch soon. > > > > Thanks, > > Jian > > > > > -----Original Message----- > > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf > > > Of Jian J Wang > > > Sent: Monday, October 23, 2017 8:51 AM > > > To: edk2-devel@lists.01.org > > > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Wolman, Ayellet > > > <ayellet.wol...@intel.com>; Yao, Jiewen <jiewen....@intel.com>; > > > Dong, Eric <eric.d...@intel.com>; Zeng, Star <star.z...@intel.com> > > > Subject: [edk2] [PATCH v3 0/6] Implement heap guard feature > > > > > > > Patch V3 changes: > > > > a. Add new protocol gEdkiiSmmMemoryAttributeProtocolGuid to do > > > > memory attributes update instead of doing it directly in > > > > SmmCore b. Fix GCC build error > > > > > > > Patch V2 changes: > > > > a. Remove local variable initializer with memory copy from globals > > > > b. Change map table dump code to use DEBUG_PAGE|DEBUG_POOL level > > > > message > > > > c. Fix malfunction in 32-bit boot mode d. Add comment for the use > > > > of mOnGuarding e. Change name of function InitializePageTableLib > > > > to > > > > InitializePageTableGlobals > > > > f. Add code in 32-bit code to bypass setting page table to > > > > read-only g. Coding style clean-up > > > > > > > > > > This feature makes use of paging mechanism to add a hidden (not > > > present) page just before and after the allocated memory block. If > > > the code tries to access memory outside of the allocated part, page > > > fault exception will be triggered. > > > > > > This feature is disabled by default and is not recommended to enable > > > it in production build of BIOS. > > > > > > Cc: Star Zeng <star.z...@intel.com> > > > Cc: Eric Dong <eric.d...@intel.com> > > > Cc: Jiewen Yao <jiewen....@intel.com> > > > Cc: Michael Kinney <michael.d.kin...@intel.com> > > > Cc: Ayellet Wolman <ayellet.wol...@intel.com> > > > Suggested-by: Ayellet Wolman <ayellet.wol...@intel.com> > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Jian J Wang <jian.j.w...@intel.com> > > > > > > Jian J Wang (6): > > > MdeModulePkg/DxeCore: Implement heap guard feature for UEFI > > > MdeModulePkg/PiSmmCore: Implement heap guard feature for SMM > > mode > > > MdeModulePkg/MdeModulePkg.dec,.uni: Add Protocol, PCDs and string > > > tokens > > > UefiCpuPkg/CpuDxe: Reduce debug message > > > UefiCpuPkg/PiSmmCpuDxeSmm: Disable page table protection > > > MdeModulePkg/DxeIpl: Enable paging for heap guard > > > > > > MdeModulePkg/Core/Dxe/DxeMain.inf | 4 + > > > MdeModulePkg/Core/Dxe/Mem/HeapGuard.c | 1184 > > > ++++++++++++++++ > > > MdeModulePkg/Core/Dxe/Mem/HeapGuard.h | 380 > > +++++ > > > MdeModulePkg/Core/Dxe/Mem/Imem.h | 38 +- > > > MdeModulePkg/Core/Dxe/Mem/Page.c | 130 +- > > > MdeModulePkg/Core/Dxe/Mem/Pool.c | 154 +- > > > MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf | 1 + > > > MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c | 29 +- > > > MdeModulePkg/Core/PiSmmCore/HeapGuard.c | 1469 > > > ++++++++++++++++++++ > > > MdeModulePkg/Core/PiSmmCore/HeapGuard.h | 399 > > ++++++ > > > MdeModulePkg/Core/PiSmmCore/Page.c | 51 +- > > > MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 7 +- > > > MdeModulePkg/Core/PiSmmCore/PiSmmCore.h | 81 +- > > > MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf | 8 + > > > MdeModulePkg/Core/PiSmmCore/Pool.c | 81 +- > > > MdeModulePkg/Include/Protocol/SmmMemoryAttribute.h | 136 ++ > > > MdeModulePkg/MdeModulePkg.dec | 60 + > > > MdeModulePkg/MdeModulePkg.uni | 58 + > > > UefiCpuPkg/CpuDxe/CpuPageTable.c | 5 +- > > > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c | 7 + > > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 20 + > > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 98 ++ > > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 2 + > > > UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 163 > > +++ > > > UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 3 +- > > > 25 files changed, 4472 insertions(+), 96 deletions(-) create mode > > > 100644 MdeModulePkg/Core/Dxe/Mem/HeapGuard.c > > > create mode 100644 MdeModulePkg/Core/Dxe/Mem/HeapGuard.h > > > create mode 100644 MdeModulePkg/Core/PiSmmCore/HeapGuard.c > > > create mode 100644 MdeModulePkg/Core/PiSmmCore/HeapGuard.h > > > create mode 100644 > > MdeModulePkg/Include/Protocol/SmmMemoryAttribute.h > > > > > > -- > > > 2.14.1.windows.1 > > > > > > _______________________________________________ > > > edk2-devel mailing list > > > edk2-devel@lists.01.org > > > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
