Hi Laszlo, > -----Original Message----- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, October 26, 2017 9:27 PM > To: Wang, Jian J <jian.j.w...@intel.com> > Cc: Yao, Jiewen <jiewen....@intel.com>; edk2-devel@lists.01.org; Kinney, > Michael D <michael.d.kin...@intel.com>; Wolman, Ayellet > <ayellet.wol...@intel.com>; Dong, Eric <eric.d...@intel.com>; Zeng, Star > <star.z...@intel.com> > Subject: Re: [edk2] [PATCH v3 0/6] Implement heap guard feature > > Hi Jian, > > On 10/26/17 09:38, Wang, Jian J wrote: > > Thanks for the feedback. > > > >> -----Original Message----- > >> From: Yao, Jiewen > >> Sent: Thursday, October 26, 2017 2:49 PM > >> To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > >> Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Wolman, Ayellet > >> <ayellet.wol...@intel.com>; Dong, Eric <eric.d...@intel.com>; Zeng, Star > >> <star.z...@intel.com>; Yao, Jiewen <jiewen....@intel.com> > >> Subject: RE: [edk2] [PATCH v3 0/6] Implement heap guard feature > >> > >> That is great work. Jian. > >> > >> Some suggestion for your consideration: > >> > >> 0) I suggest add Laszlo to review SMM part, and add Ruiyu to review > >> SMM_MEMORY_ATTRIBUTE_PROTOCOL. > >> > > > > Ok, already pinged them. > > > >> 1) Would you please mention what test we have done for this feature? > >> Such as OVMF/realPlatform? IA32/X64? > >> > > > > I did following test: > > > > Boot to shell (OVMF/Intel platform) (both IA32 and X64) > > Boot to Fedora 25 (64 only) > > May I ask if you used KVM virtualization (i.e., a Linux host computer) > for this? > > https://github.com/tianocore/tianocore.github.io/wiki/Testing-SMM-with- > QEMU,-KVM-and-libvirt >
No, I'm using Qemu on Windows. I think Qemu doesn't support VM on Windows machine but I do enabled SMM mode for it. Please let me know if there's any differences between them I should be aware of. > > Windows 10 boot loader has a limit of 512-memory-descriptor, which will > > cause boot failure. This is due to a fact that enabling this feature will > > cause > > more memory fragments (pool memory). Since this is a debug feature, I > suppose > > this is an acceptable result. > > This feature is large; I can't even attempt to review it in the time > that I could allocate to it. > > However, I would like to regression test it (thank you Jiewen for the > reference!) Preferably, given that a v4 is already planned, I should > test v4. > > If you can post v4 on Oct 27th (tomorrow), I'll make an effort to test > it in the afternoon / evening, on the 27th. (Please CC me.) Next week I > will be mostly inactive on edk2-devel -- I wouldn't like to block your > work, but I also wouldn't like an OVMF regression. > Thanks for trying. I'll try my best to send v4 today. I'd remind you in advance I have already found heap overflow (just read) in UiApp and Openssl code. > Thanks, > Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
