Laszlo: We just find this change causes XCODE5 build failure, because XCODE compiler doesn't know these two options. So, could you provide the patch to remove the change in BUILD_CFLAGS for MAC?
ifeq ($(DARWIN),Darwin) # assume clang or clang compatible flags on OS X BUILD_CFLAGS = else Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gao, > Liming > Sent: Monday, March 5, 2018 10:14 PM > To: Laszlo Ersek <ler...@redhat.com>; edk2-devel-01 <edk2-devel@lists.01.org> > Cc: Paolo Bonzini <pbonz...@redhat.com>; Cole Robinson <crobi...@redhat.com>; > Ard Biesheuvel <ard.biesheu...@linaro.org> > Subject: Re: [edk2] [PATCH 0/3] BaseTools: let the C-language build utils > compile with gcc-8 > > Reviewed-by: Liming Gao <liming....@intel.com> > > >-----Original Message----- > >From: Laszlo Ersek [mailto:ler...@redhat.com] > >Sent: Saturday, March 03, 2018 2:09 AM > >To: edk2-devel-01 <edk2-devel@lists.01.org> > >Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>; Cole Robinson > ><crobi...@redhat.com>; Gao, Liming <liming....@intel.com>; Paolo Bonzini > ><pbonz...@redhat.com>; Zhu, Yonghong <yonghong....@intel.com> > >Subject: [PATCH 0/3] BaseTools: let the C-language build utils compile with > >gcc-8 > > > >Repo: https://github.com/lersek/edk2.git > >Branch: basetools_gcc8 > > > >Once these patches are applied to the build flags and the source code of > >the build utilities themselves, OVMF builds fine with gcc-8, using the > >GCC5 toolchain settings without any changes. > > > >Regression-tested with gcc-4.8 / x86_64. > > > >Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > >Cc: Cole Robinson <crobi...@redhat.com> > >Cc: Liming Gao <liming....@intel.com> > >Cc: Paolo Bonzini <pbonz...@redhat.com> > >Cc: Yonghong Zhu <yonghong....@intel.com> > > > >Thanks > >Laszlo > > > >Laszlo Ersek (3): > > BaseTools/header.makefile: add "-Wno-stringop-truncation" > > BaseTools/header.makefile: add "-Wno-restrict" > > BaseTools/GenVtf: silence false "stringop-overflow" warning with > > memcpy() > > > > BaseTools/Source/C/Makefiles/header.makefile | 4 ++-- > > BaseTools/Source/C/GenVtf/GenVtf.c | 4 ++-- > > 2 files changed, 4 insertions(+), 4 deletions(-) > > > >-- > >2.14.1.3.gb7cf6e02401b > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
