On 03/07/18 10:12, Ard Biesheuvel wrote: > On 7 March 2018 at 09:11, Laszlo Ersek <ler...@redhat.com> wrote: >> On 03/07/18 07:43, Gao, Liming wrote: >>> Laszlo: >>> We just find this change causes XCODE5 build failure, because XCODE >>> compiler doesn't know these two options. So, could you provide the patch to >>> remove the change in BUILD_CFLAGS for MAC? >> >> Yep, I was a bit concerned about that. >> >> Ultimately I assumed that >> - clang would either recognize these warnings options (because it does >> recognize most -W options of gcc), >> - or, similarly to gcc, clang would simply ignore -Wno-* flags that it >> does not recognize. >> >> Neither appears to be the case, then. I'll send a patch soon. >> > > What is the reason we don't pass -Wno-unknown-warning-option to XCODE ?
My personal reason is that I simply didn't think of "-Wno-unknown-warning-option", for either XCODE or GCC. I just added the two new -Wno-xxx options to the GCC command line, tested them with gcc-4.8 (which knows neither of those options), and gcc-4.8 didn't complain, without needing any further massaging from my side. I assumed "ignore unknown -Wno-xxx options" was the default (vaguely recalling something like this from an earlier patch of yours -- apparently incorrectly?), and that the same would apply to XCODE too. Thanks Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
