+cc Maintainers of MdeModulePkg.

On Thu, Mar 22, 2018 at 07:39:42PM +0800, Guo Heyi wrote:
> Hi folks,
> 
> The SetAttributes() interface of generic SerialDxe driver in
> MdeModulePkg/Universal does not fully follow UEFI spec. The spec requires to 
> use
> default time out value when the input "Timeout" is 0, but the current
> implementation will set timeout to 0 directly.  It tries to pass "Timeout" to
> SerialPortSetAttributes(), but none of SerialPortLib instances in edk2 tree 
> will
> deal with this parameter. What's more, Timeout is actually a software 
> parameter
> and is only used in SerialDxe itself, not in SerialPortLib instances, so I 
> think
> it makes more sense to set Timeout in SerialDxe directly instead of in
> SerialPortLib.
> 
> Please advise.
> 
> Thanks and regards,
> 
> Heyi
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to