On 03/23/18 01:50, Zeng, Star wrote: > I agree. Wasn't there a problem with the default timeout being 1 second, and that 1 second slowing down terminal I/O on some platform? I don't remember more precisely.
Thanks Laszlo > -----Original Message----- > From: Guo Heyi [mailto:heyi....@linaro.org] > Sent: Thursday, March 22, 2018 7:43 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star <star.z...@intel.com>; Dong, Eric <eric.d...@intel.com>; Ni, > Ruiyu <ruiyu...@intel.com> > Subject: Re: MdeModulePkg/SerialDxe: SetAttributes() not follow UEFI spec > > +cc Maintainers of MdeModulePkg. > > On Thu, Mar 22, 2018 at 07:39:42PM +0800, Guo Heyi wrote: >> Hi folks, >> >> The SetAttributes() interface of generic SerialDxe driver in >> MdeModulePkg/Universal does not fully follow UEFI spec. The spec >> requires to use default time out value when the input "Timeout" is 0, >> but the current implementation will set timeout to 0 directly. It >> tries to pass "Timeout" to SerialPortSetAttributes(), but none of >> SerialPortLib instances in edk2 tree will deal with this parameter. >> What's more, Timeout is actually a software parameter and is only used >> in SerialDxe itself, not in SerialPortLib instances, so I think it >> makes more sense to set Timeout in SerialDxe directly instead of in >> SerialPortLib. >> >> Please advise. >> >> Thanks and regards, >> >> Heyi > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
