Hello Chandni,
On 15 June 2018 at 07:55, Chandni Cherukuri <chandni.cheruk...@arm.com> wrote:
> Use the platform ID and config ID values from the platform ID
> HOB to choose the right set of ACPI tables to be installed.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Chandni Cherukuri <chandni.cheruk...@arm.com>
> ---
> .../ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 33
> ++++++++++++++++++----
> .../ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 2 ++
> Platform/ARM/SgiPkg/Include/SgiPlatform.h | 24 ++++++++++++++--
> Platform/ARM/SgiPkg/SgiPlatform.dsc | 1 +
> Platform/ARM/SgiPkg/SgiPlatform.fdf | 1 +
> 5 files changed, 53 insertions(+), 8 deletions(-)
>
> diff --git a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c
> b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c
> index edaae5b..d0d5808 100644
> --- a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c
> +++ b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c
> @@ -14,6 +14,8 @@
>
> #include <Library/AcpiLib.h>
> #include <Library/DebugLib.h>
> +#include <Library/HobLib.h>
> +#include <SgiPlatform.h>
>
> EFI_STATUS
> InitVirtioBlockIo (
> @@ -28,20 +30,41 @@ ArmSgiPkgEntryPoint (
> )
> {
> EFI_STATUS Status;
> + VOID *PlatformIdHob;
> + SGI_PLATFORM_DESCRIPTOR *HobData;
> + UINT32 ConfigId;
> + UINT32 PartNum;
>
> - Status = LocateAndInstallAcpiFromFv (&gSgi575AcpiTablesiFileGuid);
> - if (EFI_ERROR (Status)) {
> - DEBUG ((DEBUG_ERROR, "%a: Failed to install ACPI tables\n",
> __FUNCTION__));
> - return Status;
> + PlatformIdHob = GetFirstGuidHob (&gArmSgiPlatformIdDescriptorGuid);
> + if (PlatformIdHob == NULL) {
> + DEBUG ((DEBUG_ERROR, "Platform ID Hob is NULL\n"));
> + return EFI_INVALID_PARAMETER;
> + }
> +
> + HobData = (SGI_PLATFORM_DESCRIPTOR *)(GET_GUID_HOB_DATA (PlatformIdHob));
> +
> + PartNum = (HobData->PlatformId & SGI_PART_NUM_MASK);
> + ConfigId = ((HobData->PlatformId >> SGI_CONFIG_SHIFT) & SGI_CONFIG_MASK);
> +
> + if ((PartNum == SGI575_PART_NUM) && (ConfigId == SGI575_CONF_NUM)) {
> + Status = LocateAndInstallAcpiFromFv (&gSgi575AcpiTablesiFileGuid);
> + if (EFI_ERROR (Status)) {
> + DEBUG ((DEBUG_ERROR, "%a: Failed to install ACPI tables\n",
> __FUNCTION__));
> + return Status;
> + }
> + } else {
> + DEBUG ((DEBUG_ERROR, "PlatformDxe: Unsupported Platform Id\n"));
> + return EFI_UNSUPPORTED;
> }
>
> - Status = EFI_REQUEST_UNLOAD_IMAGE;
> if (FeaturePcdGet (PcdVirtioSupported)) {
> Status = InitVirtioBlockIo (ImageHandle);
> if (EFI_ERROR (Status)) {
> DEBUG ((DEBUG_ERROR, "%a: Failed to install Virtio Block device\n",
> __FUNCTION__));
> }
> + } else {
> + Status = EFI_REQUEST_UNLOAD_IMAGE;
> }
>
> return Status;
> diff --git a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf
> b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf
> index 51ad22f..b6b8209 100644
> --- a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf
> +++ b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf
> @@ -30,10 +30,12 @@
>
> [LibraryClasses]
> AcpiLib
> + HobLib
> UefiDriverEntryPoint
> VirtioMmioDeviceLib
>
> [Guids]
> + gArmSgiPlatformIdDescriptorGuid
> gSgi575AcpiTablesiFileGuid
>
> [FeaturePcd]
> diff --git a/Platform/ARM/SgiPkg/Include/SgiPlatform.h
> b/Platform/ARM/SgiPkg/Include/SgiPlatform.h
> index 00ca7e9..756954c 100644
> --- a/Platform/ARM/SgiPkg/Include/SgiPlatform.h
> +++ b/Platform/ARM/SgiPkg/Include/SgiPlatform.h
> @@ -12,8 +12,8 @@
> *
> **/
>
> -#ifndef __SGI_PLATFORM_H__
> -#define __SGI_PLATFORM_H__
> +#ifndef SGI_PLATFORM_H_
> +#define SGI_PLATFORM_H_
>
>
> /***********************************************************************************
> // Platform Memory Map
> @@ -68,4 +68,22 @@
> #define SGI_SYSPH_SYS_REG_FLASH 0x4C
> #define SGI_SYSPH_SYS_REG_FLASH_RWEN 0x1
>
> -#endif // __SGI_PLATFORM_H__
> +// SGI575_VERSION values
> +#define SGI575_CONF_NUM 0x3
> +#define SGI575_PART_NUM 0x783
> +
> +#define SGI_CONFIG_MASK 0x0F
> +#define SGI_CONFIG_SHIFT 0x1C
> +#define SGI_PART_NUM_MASK 0xFFF
> +
> +//HwConfig DT structure^M
^M ?
> +typedef struct {
> + UINT64 *HwConfigDtAddr;
> +} SGI_HW_CONFIG_INFO_PPI;
> +
Please declare this PPI properly
> +// ARM platform description data.
> +typedef struct {
> + UINTN PlatformId;
> +} SGI_PLATFORM_DESCRIPTOR;
> +
> +#endif // SGI_PLATFORM_H_
> diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc
> b/Platform/ARM/SgiPkg/SgiPlatform.dsc
> index a56175e..f571897 100644
> --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc
> +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc
> @@ -199,6 +199,7 @@
> <LibraryClasses>
>
> NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> }
> + Platform/ARM/SgiPkg/Library/SgiPlatformPeiLib/SgiPlatformPeiLib.inf
>
> #
> # DXE
> diff --git a/Platform/ARM/SgiPkg/SgiPlatform.fdf
> b/Platform/ARM/SgiPkg/SgiPlatform.fdf
> index 17cdf48..05203a8 100644
> --- a/Platform/ARM/SgiPkg/SgiPlatform.fdf
> +++ b/Platform/ARM/SgiPkg/SgiPlatform.fdf
> @@ -220,6 +220,7 @@ READ_LOCK_STATUS = TRUE
> INF MdeModulePkg/Universal/FaultTolerantWritePei/FaultTolerantWritePei.inf
> INF MdeModulePkg/Universal/PCD/Pei/Pcd.inf
> INF MdeModulePkg/Universal/Variable/Pei/VariablePei.inf
> + INF Platform/ARM/SgiPkg/Library/SgiPlatformPeiLib/SgiPlatformPeiLib.inf
>
> FILE FV_IMAGE = 9E21FD93-9C72-4c15-8C4B-E77F1DB2D792 {
> SECTION GUIDED EE4E5898-3914-4259-9D6E-DC7BD79403CF PROCESSING_REQUIRED
> = TRUE {
> --
> 2.7.4
>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
