On Fri, Jun 15, 2018 at 08:19:35AM +0200, Ard Biesheuvel wrote: > On 15 June 2018 at 08:16, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > >> diff --git > >> a/Platform/ARM/SgiPkg/Library/SgiPlatformPeiLib/SgiPlatformPeiLib.inf > >> b/Platform/ARM/SgiPkg/Library/SgiPlatformPeiLib/SgiPlatformPeiLib.inf > >> new file mode 100644 > >> index 0000000..502d6ac > >> --- /dev/null > >> +++ b/Platform/ARM/SgiPkg/Library/SgiPlatformPeiLib/SgiPlatformPeiLib.inf > >> @@ -0,0 +1,40 @@ > >> +# > >> +# Copyright (c) 2018, ARM Limited. All rights reserved. > >> +# > >> +# This program and the accompanying materials are licensed and made > >> available > >> +# under the terms and conditions of the BSD License which accompanies > >> this > >> +# distribution. The full text of the license may be found at > >> +# http://opensource.org/licenses/bsd-license.php > >> +# > >> +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > >> +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > >> IMPLIED. > >> +# > >> + > >> +[Defines] > >> + INF_VERSION = 0x0001001A > >> + BASE_NAME = SgiPlatformIdPeiLib > > I forgot: this is a module not a library. So it should be called > SgiPlatformIdPei or SgiPlatformIdPeim not ...Lib
A grep through the edk2 tree suggests that: - the directory is usually called *Pei - .inf/.uni usually *Pei.* - entry point and source files *Peim* / Leif > >> + FILE_GUID = a9936f3e-6a1b-11e8-8ce0-fffe69b86863 > >> + MODULE_TYPE = PEIM > >> + VERSION_STRING = 1.0 > >> + ENTRY_POINT = SgiPlatformIdPeim > >> + > >> +[Packages] > >> + EmbeddedPkg/EmbeddedPkg.dec > >> + MdePkg/MdePkg.dec > >> + Platform/ARM/SgiPkg/SgiPlatform.dec > >> + > >> +[LibraryClasses] > >> + FdtLib > >> + PeimEntryPoint > >> + > >> +[Sources] > >> + SgiPlatformPeiLib.c > >> + > >> +[Guids] > >> + gArmSgiPlatformIdDescriptorGuid > >> + > >> +[Ppis] > >> + gHwConfigDtInfoPpiGuid > >> + > >> +[Depex] > >> + TRUE > >> diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dec > >> b/Platform/ARM/SgiPkg/SgiPlatform.dec > >> index d995937..ea9f6c5 100644 > >> --- a/Platform/ARM/SgiPkg/SgiPlatform.dec > >> +++ b/Platform/ARM/SgiPkg/SgiPlatform.dec > >> @@ -29,9 +29,14 @@ > >> Include # Root include for the package > >> > >> [Guids.common] > >> + # ARM Sgi Platform ID descriptor > >> + gArmSgiPlatformIdDescriptorGuid = { 0xf56f152a, 0xad2a, 0x11e6, { 0xb1, > >> 0xa7, 0x00, 0x50, 0x56, 0x3c, 0x44, 0xcc } } > >> gArmSgiTokenSpaceGuid = { 0x577d6941, 0xaea1, 0x40b4, { 0x90, > >> 0x93, 0x2a, 0x86, 0x61, 0x72, 0x5a, 0x57 } } > >> gSgi575AcpiTablesiFileGuid = { 0xc712719a, 0x0aaf, 0x438c, { 0x9c, > >> 0xdd, 0x35, 0xab, 0x4d, 0x60, 0x20, 0x7d } } > >> > >> [PcdsFeatureFlag.common] > >> # Set this PCD to TRUE to enable virtio support. > >> gArmSgiTokenSpaceGuid.PcdVirtioSupported|TRUE|BOOLEAN|0x00000001 > >> + > >> +[Ppis] > >> + gHwConfigDtInfoPpiGuid = { 0x6f606eb3, 0x9123, 0x4e15, { 0xa8, > >> 0x9b, 0x0f, 0xac, 0x66, 0xef, 0xd0, 0x17 } } > >> -- > >> 2.7.4 > >> _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel