On Wed, Nov 14, 2018 at 07:16:33AM +0100, Marcin Wojtas wrote: > Hi Leif, > > śr., 14 lis 2018 o 02:12 Leif Lindholm <leif.lindh...@linaro.org> napisał(a): > > > > On Sat, Oct 20, 2018 at 03:57:31AM +0200, Marcin Wojtas wrote: > > > This patch extends library with GPIO devices per-board > > > description. Both embedded SoC controllers and > > > I2C IO expanders are supported. Add a helper routine > > > for obtaining information about the latter. > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Marcin Wojtas <m...@semihalf.com> > > > --- > > > Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h | 23 > > > ++++++++++++++++++++ > > > 1 file changed, 23 insertions(+) > > > > > > diff --git a/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h > > > b/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h > > > index ee8e06e..109164c 100644 > > > --- a/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h > > > +++ b/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h > > > @@ -25,6 +25,29 @@ typedef struct { > > > } MV_BOARD_COMPHY_DESC; > > > > > > // > > > +// GPIO devices per-board description > > > +// > > > +typedef struct { > > > + UINTN ChipId; > > > + UINTN I2cAddress; > > > + UINTN I2cBus; > > > +} MV_I2C_IO_EXPANDER_DESC; > > > + > > > +typedef struct { > > > + MV_SOC_GPIO_DESC *SoC; > > > + UINTN GpioDevCount; > > > + MV_I2C_IO_EXPANDER_DESC *I2cIoExpanderDesc; > > > + UINTN I2cIoExpanderCount; > > > +} MV_BOARD_GPIO_DESC; > > > + > > > +EFI_STATUS > > > +EFIAPI > > > +ArmadaBoardDescGpioGet ( > > > + IN OUT MV_I2C_IO_EXPANDER_DESC **I2cIoExpanderDesc, > > > + IN OUT UINTN *I2cIoExpanderCount > > > > Please expand all DESC/Desc to descriptor/description/whatever as > > appropriate. > > Just to confirm - until now in every case there was an abbreviation > used (in SoCDescLib, structures names, etc.). It may look somewhat > inconsistently, but of course I can change according to your wish. > Please let know your thoughts on that.
Well, I'd prefer to change it all, but I'm happy to stick to following the coding style for new patches. / Leif _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel