On Wed, Nov 14, 2018 at 07:05:01AM +0100, Marcin Wojtas wrote:
> > I think all of my comments on this patch can be summarised as "what is
> > an AP in this context"?
> >
> > The term either needs explicit documenting, or expansion in the macro
> > names such that documentation is not required.
>
> Isn't a glossary on top of this file:
> https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/blob/8ff9b13675a401588d3cc999aef9891838047b18/Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h#L13
> and C file:
> https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/blob/8ff9b13675a401588d3cc999aef9891838047b18/Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c#L13
> sufficient?
I will confess I missed that. But that also clearly shows the problem.
The glossary in is sufficient according to the coding style.
But it gets confusing, specifically for the abbreviation "AP", since
this has a specific (and different) meaning in PI.
/
Leif
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
