On 11/27/18 22:55, Brian J. Johnson wrote: > On 11/27/18 6:53 AM, Laszlo Ersek wrote: >> On 11/26/18 22:43, Jeremiah Cox via edk2-devel wrote: >>> Feedback on GitHub as follows… >>> >>> >>>> 1. No Lock-In - What automated data export is available? >>>> We want to be able to leave and take all our data with us. "Data" here >>>> includes: review comments, pull requests / patches (including >>>> metadata), >>>> old (rejected) pull requests and metadata, issue tracker entries and >>>> comments (if issue tracker included). This archiving should be >>>> automated, not something we do by hand. >>> Untested, but might these all be easily satisfied by subscribing a >>> mailing list to GitHub notifications? >>> https://help.github.com/articles/about-notifications/#watching-notifications >>> >>> https://help.github.com/articles/about-email-notifications/ >> No, they are insufficient. >> >> Following the last link above ("about-email-notifications"), one finds >> several other links; and one of those is: >> >> https://help.github.com/articles/about-notifications/ >> >> This article says, >> >> GitHub sends participating notifications when you're directly >> involved in activities or conversations within a repository or a >> team you're a member of. You'll receive a notification when: >> >> [...] >> >> - You open, comment on, or close an issue or pull request. >> >> [...] >> >> This is demonstrably false. I'm a member of the TianoCore organization, >> I have commented on, and closed (rejected): >> >> https://github.com/tianocore/edk2/pull/133 >> >> and I *never* received an email notification about my *own* comment / >> action. I only received the initial email, about the pull request being >> opened (attached for reference). > > Try going to the "Settings" item under the menu in the top-right corner, > and clicking on the "Notifications" tab on the left. Under "Email > notification preferences" there should be a checkbox for "Include your > own updates". That may do what you need.
That did the trick. I checked the box and then went on to close PR#134. I got two separate emails shortly after (attached), one about the closure and another about the comment. In my opinion, the default value for the setting in question is broken (it should be "on" by default). However, to me anyway, it's a big plus for GitHub that it actually supports this feature. If we are going to adopt GitHub, then we can highlight the knob in our docs. Regarding GitHub, what remains to be seen (for me) is if & how it preserves old (unmerged) topic branches, and review comments made for them, after the pull requestor rebases or deletes those branches in his/her repo. Can someone please send an artificial/test PR against my personal repo, at <https://github.com/lersek/edk2>? Just change some lines in OvmfPkg/README or something like that. Thank you! Laszlo
--- Begin Message ---Closed #134. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tianocore/edk2/pull/134#event-1992063250
--- End Message ---
--- Begin Message ---Sorry about the late followup. For now, please subscribe to the edk2-devel mailing list, and submit your patch as a normal git patch email, for review. https://lists.01.org/mailman/listinfo/edk2-devel For now, I'm going to have to close this PR, but this action is entirely independent of the topic & quality of your patch. I encourage you to submit your patch to the list please. The edk2 community is in the process of researching new methods to contribute, which many developers might find more convenient than the mailing list based workflow. Please refer to the wiki article at https://github.com/tianocore/tianocore.github.io/wiki/Community-Virtual-Meetings . Also, I recommend participating in the thread `[edk2] [edk2-announce] Research Request`. The archive is at https://lists.01.org/pipermail/edk2-devel/2018-November/032459.html . -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tianocore/edk2/pull/134#issuecomment-442401567
--- End Message ---
_______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
