On 1/31/2019 3:51 PM, Ard Biesheuvel wrote:
The POC code is inhttps://github.com/jyao1/edk2/tree/ReOrg.
It basically split the EDKII common code to three directories:
Core/, Device/, and Feature/.
I'm not sure I like the 'Device' name, but that's not that important
at this stage - I like that this is split up the way it is.
I also think a lot of things currently under Feture/misc could be
broken out into additional subdirectories under Feature/.
The code is in very early POC phase and only code in Core/ directory
can pass the build.
I would like to gather feedbacks through this RFC to see whether
this splitting direction makes sense.
Is there any other better ways of splitting?
Or perhaps do not split in such a small granularity?
I think this would be my only negative(ish) feedback on the POC.
While it has the benefit of modules requiring to specify more
precisely which functionality they are pulling in...
...it means that they now need to list*everything*.
And with the mechanism by which I have seen Intel engineers make use
of PACKAGES_PATH in the past*, we end up with a bazillion packages
that need to be added individually to this variable for each build.
No. "PACKAGES_PATH" only contains paths pointing to the*parent*
directory of *Pkg. In this case, it equals to:
/work/edk2/Core:/work/edk2/Device:/work/edk2/Feature/security:/work/edk2/Feature/network:/work/edk2/Feature/misc
Could we*please* not do this? PACKAGES_PATH is very useful for
combining packages from different repositories, but that does not mean
we should split up the core repository in this way.
What we will end up with is platforms that use
Core/Package/Foo.inf
and platforms that use
Package/Foo.inf
which creates an aliasing mess where the same file is reachable in
different ways. Also, it encourages the behavior where you need to
fetch version X of repo A and version Y of repo B, and the whole point
of open sourcing is to have all code co-exist in the same source tree.
Ard,
Some platforms which define PACKAGES_PATH to "/work/edk2" will have
"Core/Package/Foo.inf" in the DSC/FDF.
Some platforms which define PACKAGES_PATH to "/work/edk2/Core" will have
"Package/Foo.inf" in the DSC/FDF.
It's bad and I 100% agree!
The basic rule behind that is PACKAGES_PATH should only contains path
pointing to the root of repo.
Thanks for raising a very good concern on putting packages inside
sub-directory.
--
Thanks,
Ray
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
