On Fri, 2013-02-08 at 20:08 -0800, Jordan Justen wrote: > On Mon, Jan 28, 2013 at 3:31 PM, David Woodhouse <[email protected]> wrote: > > --- a/OvmfPkg/Library/LoadLinuxLib/Ia32/JumpToKernel.S > > +++ b/OvmfPkg/Library/LoadLinuxLib/Ia32/JumpToKernel.S > > +ASM_PFX(JumpToUefiKernel): > > + movl 0xc(%esp), %eax > > + movl 0x264(%eax), %eax > > Can't handover_offset be used here?
That *is* using handover_offset, which is at 0x264 from %eax; the pointer to the start of the structure. > If you need to update this, can you start with your (slightly tweaked) > changes in? > git://github.com/jljusten/edk2.git reviews-20130208 > > > --- a/OvmfPkg/Library/LoadLinuxLib/X64/JumpToKernel.S > > +++ b/OvmfPkg/Library/LoadLinuxLib/X64/JumpToKernel.S > > +ASM_PFX(JumpToUefiKernel): > > + movl 0x264(%r8), %eax > > + addq %rax, %r9 > > + addq $0x200, %r9 > > handover_offset + 0x200? Don't talk to me about that 0x200. It just makes me sad. > Or, perhaps change the KernelStart param to UefiHandover? > > You previously asked about the 0x200 for X64 in the assembly. There is > no good reason for this, so you can take care of that part in C > instead. But I think I'd still need to play silly buggers to cope with the fact that I'm not really allowed to do void* arithmetic on certain toolchains? On the whole, I'm happy with it as it stands at the moment; it's fairly well tested and there's nothing particularly wrong with it. Your sizeof(UINTN)==4?BIT2:BIT3 will be fine. Unless you have specific demands for changes, I'm happy with what's in your tree. Apologies if the above *was* a demand for a specific change and I'm just too dim to spot it this morning... :) -- dwmw2
smime.p7s
Description: S/MIME cryptographic signature
------------------------------------------------------------------------------ Free Next-Gen Firewall Hardware Offer Buy your Sophos next-gen firewall before the end March 2013 and get the hardware for free! Learn more. http://p.sf.net/sfu/sophos-d2d-feb
_______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
