Sorry, I miss the patch you send to me.
Check in code in patch: 14538, please help to verify.
Thanks,
Eric
From: Sergey Isakov [mailto:[email protected]]
Sent: Friday, August 09, 2013 3:38 PM
To: [email protected]
Subject: Re: [edk2] Notify code check in: [PATCH]MdeModulePkg/SetupBrowserDxe:
Remodel setup browser driver to provide customization possibilities
Thank you for the notification
but I can't understand this mistake
------------
In file included from
/Users/Sergey/src/edk2/MdeModulePkg/Universal/SetupBrowserDxe/Setup.h:25:0,
from
/Users/Sergey/src/edk2/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c:15:
/Users/Sergey/src/edk2/MdeModulePkg/Include/Protocol/FormBrowserEx2.h:19:36:
fatal error: Protocol\FormBrowserEx.h: No such file or directory
#include <Protocol\FormBrowserEx.h>
^
compilation terminated.
------------
The file if actually present but it seems an order of loading is significant
09.08.2013, в 10:39, Dong, Eric написал(а):
Hi All,
I have checked in this patch at revision 14537. In my patch , I update
OVMF/NT32/Duet platform to include new display engine and customized display
library. If any other platform also use browser and not include by my patch,
platform owner need to update these platforms to include new display engine and
customized display library, otherwise it may cause this platform can enter the
setup page.
I copy sample code from Duet platform, shows how to change platform code:
Modified: trunk/edk2/DuetPkg/DuetPkg.fdf
===================================================================
--- trunk/edk2/DuetPkg/DuetPkg.fdf 2013-08-09 05:23:22 UTC (rev 14536)
+++ trunk/edk2/DuetPkg/DuetPkg.fdf 2013-08-09 05:26:47 UTC (rev 14537)
@@ -59,6 +59,7 @@
INF MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf
INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
+INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
INF MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf
INF MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf
Modified: trunk/edk2/DuetPkg/DuetPkgIa32.dsc
===================================================================
--- trunk/edk2/DuetPkg/DuetPkgIa32.dsc 2013-08-09 05:23:22 UTC (rev
14536)
+++ trunk/edk2/DuetPkg/DuetPkgIa32.dsc 2013-08-09 05:26:47 UTC (rev
14537)
@@ -85,6 +85,7 @@
SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf
CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeCoffExtraActionLibNull.inf
+
CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf
#
# Platform
#
@@ -191,6 +192,7 @@
}
MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
+ MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf
MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf
Thanks,
Eric
From: Dong, Eric [mailto:[email protected]]
Sent: Tuesday, July 23, 2013 3:21 PM
To: [email protected]<mailto:[email protected]>
Subject: [edk2] [PATCH]MdeModulePkg/SetupBrowserDxe: Remodel setup browser
driver to provide customization possibilities
=======================
MdeModulePkg: Remodel SetupBrowserDxe driver
Current browser driver combines all functions in one driver; it's hard for user
to customize the diver for different look and feel. After remodel the browser
driver, browser driver will be divided into two drivers and one library:
SetupBrowserDxe: maintain the main process from IFR data; it will convert the
IFR data to display data structure.
DisplayEngineDxe: maintain the display process, based on the input display data
structure get from SetupBrowserDxe.
CustomizedDisplayLib: export some display related interface for user to
customize, used by DisplayEngineDxe driver.
After remodeling, user can add their CustomizedDisplayLib or DisplayEngineDxe
for different user experience.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <[email protected]<mailto:[email protected]>>
=======================
DuetPkg/Nt32Pkg/OvmfPkg: Update the platform DSC/FDF file to use new browser
related drivers.
=======================
[Impact]
1. All related platform need to update dsc and fdf file to include new
driver and library.
Thanks,
Eric
------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead.
Download for free and get started troubleshooting in minutes.
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk_______________________________________________
edk2-devel mailing list
[email protected]<mailto:[email protected]>
https://lists.sourceforge.net/lists/listinfo/edk2-devel
------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead.
Download for free and get started troubleshooting in minutes.
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
